Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] plpgsql grammar file needs to be made consistent with YB grammar #2005

Closed
ndeodhar opened this issue Aug 8, 2019 · 0 comments
Closed

[YSQL] plpgsql grammar file needs to be made consistent with YB grammar #2005

ndeodhar opened this issue Aug 8, 2019 · 0 comments
Assignees
@Zhongweizhao
Labels
area/ysql Yugabyte SQL (YSQL)

Comments

@ndeodhar
Copy link
Contributor

ndeodhar commented Aug 8, 2019

plpgsql uses a separate grammar file pl_gram.y, which means that plpgsql functions will end up not throwing parsing errors even for unsupported YB commands, leading to unexpected behavior.
We need to make that grammar consistent with YB grammar in gram.y.
@ndeodhar ndeodhar added the area/ysql Yugabyte SQL (YSQL) label Aug 8, 2019
@ndeodhar ndeodhar assigned Zhongweizhao and unassigned m-iancu and ndeodhar Sep 11, 2019
Zhongweizhao pushed a commit that referenced this issue Dec 17, 2019
[YSQL]: #2005 Correctly report unsupported features in plpgsql grammar
3da36dc 
Summary:
plpgsql and regular sql have a number of common features.
In Yugabyte some of these are not yet supported but were only marked/reported as such in the regular grammar.
This updates the plpgsql grammar file to make it consistent with YB SQL grammar with respect to unsupported features.

Test Plan: added yb_plpgsql regress test, existing plpgsql tests

Reviewers: neha, mihnea

Reviewed By: mihnea

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D7248
@ndeodhar ndeodhar mentioned this issue Jun 5, 2020
Closed
@m-iancu m-iancu mentioned this issue Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zhongweizhao Zhongweizhao

Labels
area/ysql Yugabyte SQL (YSQL)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m-iancu @ndeodhar @Zhongweizhao