Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Implement backward scan support for GetTableKeyRanges API #19342

Closed
1 task done
Tracked by #17984
ttyusupov opened this issue Sep 28, 2023 · 0 comments
Closed
1 task done
Tracked by #17984

[DocDB] Implement backward scan support for GetTableKeyRanges API #19342

ttyusupov opened this issue Sep 28, 2023 · 0 comments
Assignees
@ttyusupov
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@ttyusupov
Copy link
Contributor

ttyusupov commented Sep 28, 2023 •
edited by jira bot
Loading

Jira Link: DB-8144

Description

Sub-task for #17986.

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@ttyusupov ttyusupov added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Sep 28, 2023
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Sep 28, 2023
@ttyusupov ttyusupov changed the title [DocDB] Implement Backward scan support for GetTableKeyRanges API [DocDB] Implement backward scan support for GetTableKeyRanges API Sep 28, 2023
@ttyusupov ttyusupov mentioned this issue Sep 17, 2023
Open
10 tasks
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Oct 10, 2023
ttyusupov added a commit that referenced this issue Mar 21, 2024
@ttyusupov
[#19342] docdb: Implement backward scan support for GetTableKeyRanges…
cb302e0 
… API

Summary:
- Implemented backward scan support for GetTableKeyRanges API.
- Tablet::GetTabletKeyRanges - limited to colocated range-sharded tables for now
- Updated QLTabletRf1TestToggleEnablePackedRow.GetTabletKeyRanges, PggateTestSelect.GetColocatedTableKeyRanges tests
- Disabled PggateTestSelect.GetTableKeyRanges till we support non-colocated use case
- Added rocksdb::Iterator::KeyDebugHexString()
- Removed GetTabletKeyRangesEmbeddedRequestPB.is_forward

**Upgrade/Rollback safety:**
`GetTabletKeyRangesEmbeddedRequestPB` only affects RPCs within the same node between pggate and local tserver, so it is safe to change.
Jira: DB-8144

Test Plan: QLTabletRf1TestToggleEnablePackedRow.GetTabletKeyRanges, PggateTestSelect.GetColocatedTableKeyRanges

Reviewers: arybochkin

Reviewed By: arybochkin

Subscribers: yql, ybase, bogdan

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D32519
ttyusupov added a commit that referenced this issue May 3, 2024
@ttyusupov
[BACKPORT 2024.1][#19342] docdb: Implement backward scan support for …
f66d1c0 
…GetTableKeyRanges API

Summary:
- Implemented backward scan support for GetTableKeyRanges API.
- Tablet::GetTabletKeyRanges - limited to colocated range-sharded tables for now
- Updated QLTabletRf1TestToggleEnablePackedRow.GetTabletKeyRanges, PggateTestSelect.GetColocatedTableKeyRanges tests
- Disabled PggateTestSelect.GetTableKeyRanges till we support non-colocated use case
- Added rocksdb::Iterator::KeyDebugHexString()
- Removed GetTabletKeyRangesEmbeddedRequestPB.is_forward

**Upgrade/Rollback safety:**
`GetTabletKeyRangesEmbeddedRequestPB` only affects RPCs within the same node between pggate and local tserver, so it is safe to change.
Jira: DB-8144

Original commit: cb302e0 / D32519

Test Plan: QLTabletRf1TestToggleEnablePackedRow.GetTabletKeyRanges, PggateTestSelect.GetColocatedTableKeyRanges

Reviewers: arybochkin, rthallam

Reviewed By: rthallam

Subscribers: ybase, yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34696
ZhenYongFan pushed a commit to ZhenYongFan/yugabyte-db that referenced this issue Jun 15, 2024
@ttyusupov
[BACKPORT 2024.1][yugabyte#19342] docdb: Implement backward scan supp…
41f6c17 
…ort for GetTableKeyRanges API

Summary:
- Implemented backward scan support for GetTableKeyRanges API.
- Tablet::GetTabletKeyRanges - limited to colocated range-sharded tables for now
- Updated QLTabletRf1TestToggleEnablePackedRow.GetTabletKeyRanges, PggateTestSelect.GetColocatedTableKeyRanges tests
- Disabled PggateTestSelect.GetTableKeyRanges till we support non-colocated use case
- Added rocksdb::Iterator::KeyDebugHexString()
- Removed GetTabletKeyRangesEmbeddedRequestPB.is_forward

**Upgrade/Rollback safety:**
`GetTabletKeyRangesEmbeddedRequestPB` only affects RPCs within the same node between pggate and local tserver, so it is safe to change.
Jira: DB-8144

Original commit: cb302e0 / D32519

Test Plan: QLTabletRf1TestToggleEnablePackedRow.GetTabletKeyRanges, PggateTestSelect.GetColocatedTableKeyRanges

Reviewers: arybochkin, rthallam

Reviewed By: rthallam

Subscribers: ybase, yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttyusupov ttyusupov

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ttyusupov @yugabyte-ci