Skip to content

Commit

Permalink
[#23148] CDC: Reduce logging frequency for warning about safe hybrid …
Browse files Browse the repository at this point in the history
…time not being present

Summary:
This diff makes a change to the log macro where the warning will now be logged at every 10 minutes i.e. 600s instead of being logged at every 10000th request.

Note that this log will only be printed when the checkpointing type is `IMPLICIT`.
Jira: DB-12089

Test Plan: Run existing tests.

Reviewers: skumar, siddharth.shah, sumukh.phalgaonkar

Reviewed By: skumar

Subscribers: ycdcxcluster

Differential Revision: https://phorge.dev.yugabyte.com/D41056
  • Loading branch information
vaibhav-yb committed Jan 10, 2025
1 parent e3b6761 commit f735e24
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/yb/cdc/cdc_service.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1909,7 +1909,7 @@ void CDCServiceImpl::GetChanges(
} else if (req->safe_hybrid_time() != -1) {
cdc_sdk_safe_time = HybridTime::FromPB(req->safe_hybrid_time());
} else {
YB_LOG_EVERY_N(WARNING, 10000)
YB_LOG_EVERY_N_SECS(WARNING, 600)
<< "safe_hybrid_time is not present in request, using response to get safe_hybrid_time";
cdc_sdk_safe_time = HybridTime::FromPB(resp->safe_hybrid_time());
}
Expand Down

0 comments on commit f735e24

Please sign in to comment.