[#1525][Platform][2.4 backport] New Universe creation gets public IP …

…assigned even with flag = false

Summary:
When creating the universe, while choosing the node and replication factor, the nodeDetailsSet is added to the configuration. The assignPublicIP field in the nodeDetailsSet takes the current value of the assignPublicIP form value.
So, later even if we change the value of assignPublicIP in form, it is not getting modified inside the nodeDetailsSet. This gets passed to the platform, and the platform creates nodes corresponding to the values present in the nodeDetailsSet , causing this discrepancy.

Fix:
Before submitting the form, we iterate through all of the nodeDetailsSet and assign the form value of the assignPublicIP to each the nodes inside nodeDetailsSet.

Test Plan:
Steps followed:

Choose Provider
toggle off the assignPublicIP
configure regions, nodes and replication factor.
Turn on the assignPublicIP
check , if the newly created universe has the public ip.
and reversed the initial state of the toggle and tested again.

The universe doesn't have the public IP (Actually, we can't test this scenario in portal. We need to subnet to test. The universe simple won't come up).

Reviewers: ssutar, mjoshi, cpadinjareveettil

Reviewed By: cpadinjareveettil

Subscribers: jenkins-bot, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D12764

managed/ui/src/components/universes/UniverseForm/UniverseForm.js

@@ -496,6 +496,16 @@ class UniverseForm extends Component {
       ];
     }
 
+    submitPayload.nodeDetailsSet = submitPayload.nodeDetailsSet.map(nodeDetail => {
+      return {
+        ...nodeDetail,
+        cloudInfo: {
+          ...nodeDetail.cloudInfo,
+          assignPublicIP: formValues["primary"].assignPublicIP
+        }
+      }
+    })
+
     submitPayload.clusters = submitPayload.clusters.filter((c) => c.userIntent !== null);
     // filter clusters array if configuring(adding only) Read Replica due to server side validation
     if (type === 'Async') {