[YSQL] yb-admin create_database_snapshot should not require ysql pref…

…ix for database name (#4991)

Summary:
Adding option to specify default db type in ParseNamespaceName
 - if there is a prefix then we still respect it, otherwise default to `default_if_no_prefix`

Test Plan:
Running
```
yb-admin -master_addresses 127.0.0.1:7100 create_database_snapshot test
```
Should no longer produce any errors about wrong database types.

Reviewers: neha

Reviewed By: neha

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D8858

ent/src/yb/tools/yb-admin_cli_ent.cc

@@ -112,7 +112,8 @@ void ClusterAdminCli::RegisterCommandHandlers(ClusterAdminClientClass* client) {
           return ClusterAdminCli::kInvalidArguments;
         }
 
-        const TypedNamespaceName database = VERIFY_RESULT(ParseNamespaceName(args[2]));
+        const TypedNamespaceName database =
+            VERIFY_RESULT(ParseNamespaceName(args[2], YQL_DATABASE_PGSQL));
         SCHECK_EQ(
             database.db_type, YQL_DATABASE_PGSQL, InvalidArgument,
             Format("Wrong database type: $0", YQLDatabase_Name(database.db_type)));

src/yb/tools/yb-admin_client.cc

@@ -191,7 +191,10 @@ const char* DatabasePrefix(YQLDatabase db) {
   return kDBTypePrefixUnknown;
 }
 
-Result<TypedNamespaceName> ResolveNamespaceName(const Slice& prefix, const Slice& name) {
+Result<TypedNamespaceName> ResolveNamespaceName(
+    const Slice& prefix,
+    const Slice& name,
+    const YQLDatabase default_if_no_prefix = YQL_DATABASE_CQL) {
   auto db_type = YQL_DATABASE_UNKNOWN;
   if (!prefix.empty()) {
     static const std::array<pair<const char*, YQLDatabase>, 3> type_prefixes{
@@ -209,7 +212,7 @@ Result<TypedNamespaceName> ResolveNamespaceName(const Slice& prefix, const Slice
       return STATUS_FORMAT(InvalidArgument, "Invalid db type name '$0'", prefix);
     }
   } else {
-    db_type = (name == common::kRedisKeyspaceName ? YQL_DATABASE_REDIS : YQL_DATABASE_CQL);
+    db_type = (name == common::kRedisKeyspaceName ? YQL_DATABASE_REDIS : default_if_no_prefix);
   }
   return TypedNamespaceName{.db_type = db_type, .name = name.cdata()};
 }
@@ -1748,9 +1751,10 @@ string RightPadToUuidWidth(const string &s) {
   return RightPadToWidth(s, kNumCharactersInUuid);
 }
 
-Result<TypedNamespaceName> ParseNamespaceName(const std::string& full_namespace_name) {
+Result<TypedNamespaceName> ParseNamespaceName(const std::string& full_namespace_name,
+                                              const YQLDatabase default_if_no_prefix) {
   const auto parts = SplitByDot(full_namespace_name);
-  return ResolveNamespaceName(parts.prefix, parts.value);
+  return ResolveNamespaceName(parts.prefix, parts.value, default_if_no_prefix);
 }
 
 }  // namespace tools

src/yb/tools/yb-admin_client.h

@@ -322,7 +322,9 @@ static constexpr const char* kColumnSep = " \t";
 
 std::string RightPadToUuidWidth(const std::string &s);
 
-Result<TypedNamespaceName> ParseNamespaceName(const std::string& full_namespace_name);
+Result<TypedNamespaceName> ParseNamespaceName(
+    const std::string& full_namespace_name,
+    const YQLDatabase default_if_no_prefix = YQL_DATABASE_CQL);
 
 }  // namespace tools
 }  // namespace yb