Skip to content

Commit

Permalink
[BACKPORT 2.20.2][PLAT-13161]: Fix restore autoflag check
Browse files Browse the repository at this point in the history
Summary:
While fetching autoflags on target universe, we were extracting master autoflags instead of tserver autoflags while comparing tserverautoflags of backup.
original diff/commit: D33268

Test Plan: Tested manually by creating 2 universe, where one universe has ysql_enable_packed_row in disabled state, so the restore is expected to fail but after setting it on other universe through gflags upgrade, restore passes.

Reviewers: svarshney

Reviewed By: svarshney

Subscribers: yugaware

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D33276
  • Loading branch information
vipul-yb committed Mar 18, 2024
1 parent f54b95b commit 09aa325
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,7 @@ public boolean validateAutoFlagCompatibility(
Set<String> targetTServerAutoFlags =
autoFlagUtil.getPromotedAutoFlags(
universe,
UniverseTaskBase.ServerType.MASTER,
UniverseTaskBase.ServerType.TSERVER,
AutoFlagUtil.LOCAL_PERSISTED_AUTO_FLAG_CLASS);
for (String flag : tserverAutoFlags) {
if (GFlagsValidation.TEST_AUTO_FLAGS.contains(flag)) {
Expand Down

0 comments on commit 09aa325

Please sign in to comment.