Skip to content

Commit

Permalink
This commit provides additional functionality that is logically relat…
Browse files Browse the repository at this point in the history
…ed to the

earlier commit 41b9a6e

Original commit message:

#384 Rename ApplyAsync to ApplyOperation and get rid of the unused apply thread pool

Summary:
To paraphrase @lorinlee on #384: The function name
OperationDriver::ApplyAsync is confusing, and the comments of this function is outdated. It says
that "ApplyAsync() submits ApplyTask() to the apply_pool_", but in fact it is not true. The
invocation of this function is synchronous. Also, apply_pool_ in OperationDriver and even TabletPeer
should be removed because they are not being used.

Test Plan: Jenkins

Reviewers: sergei, bogdan, hector

Reviewed By: hector

Subscribers: bharat, kannan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D5292
  • Loading branch information
mbautin committed Jul 11, 2019
1 parent ae23790 commit 037b536
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ent/src/yb/tablet/tablet_peer.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ class TabletPeer : public yb::tablet::TabletPeer{
typedef yb::tablet::TabletPeer super;
public:
TabletPeer(const scoped_refptr<TabletMetadata>& meta,
const consensus::RaftPeerPB& local_peer_pb, ThreadPool* apply_pool,
const consensus::RaftPeerPB& local_peer_pb,
Callback<void(std::shared_ptr<StateChangeContext> context)> mark_dirty_clbk)
: super(meta, local_peer_pb, apply_pool, mark_dirty_clbk) {}
: super(meta, local_peer_pb, mark_dirty_clbk) {}

protected:
std::unique_ptr<Operation> CreateOperation(consensus::ReplicateMsg* replicate_msg) override;
Expand Down

0 comments on commit 037b536

Please sign in to comment.