[2024.1] Separate FIPS version from other OpenSSL version, bump OpenSSL to 3.0.15 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
es1024
force-pushed
the
2024.1
branch
3 times, most recently
from
656c7d3 to
f35bac1
Compare
mbautin
approved these changes
Oct 23, 2024
Comment on lines
+42
to
+47
| # Patch fixes the following error on kernel versions < 4.1.0: | ||
| # ld.lld: error: version script assignment of 'global' to symbol 'bind_engine' failed: | ||
| # symbol not defined | ||
| # ld.lld: error: version script assignment of 'global' to symbol 'v_check' failed: | ||
| # symbol not defined | ||
| self.patches = ['openssl-fix-afalg-link-on-centos7.patch'] |
There was a problem hiding this comment.
Perhaps a better approach to patch management is to create a yugabyte fork of the upstream project, push our code there along with our patches in a separate branch, and create a tag. If you think that is a good idea, feel free to do that as a separate change.
There was a problem hiding this comment.
I think for this patch we might actually be able to drop it entirely from both OpenSSL builds -- CentOS 7 should be the only build target we had that ran on a linux kernel under 4.1.0, and we don't build that anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping OpenSSL to 3.0.15. FIPS must stay on 3.0.8, so separating the two. Same as #285
Also moved aarch64 builds from CircleCI (which no longer works) to GitHub Actions and removed EOL CentOS 7 builds.