Skip to content

Commit

Permalink
address shell-check
Browse files Browse the repository at this point in the history
  • Loading branch information
svarnau committed Nov 8, 2024
1 parent 32743d2 commit fd95460
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
5 changes: 1 addition & 4 deletions build_and_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,8 @@ tools_to_show_versions=(
autoreconf
cmake
pkg-config
python3
python3.9
python
"${PYTHON:-python3}"
)
echo "path: $PATH"

if [[ $OSTYPE == darwin* ]]; then
tools_to_show_versions+=( shasum )
Expand Down
2 changes: 1 addition & 1 deletion build_thirdparty.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ echo
echo "Logging to ${log_path} (linked to ${link_path_list_str})"
echo

cmd=( ${PYTHON:-python3}
cmd=( "${PYTHON:-python3}"
"${YB_THIRDPARTY_DIR}/python/yugabyte_db_thirdparty/yb_build_thirdparty_main.py" )
if [[ ${#build_thirdparty_args[@]} -gt 0 ]]; then
cmd+=( "${build_thirdparty_args[@]}" )
Expand Down
2 changes: 1 addition & 1 deletion yb-thirdparty-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ compute_sha256sum() {

activate_virtualenv() {
if [[ ! -d $YB_THIRDPARTY_DIR/venv ]]; then
${PYTHON:-python3} -m venv "$YB_THIRDPARTY_DIR/venv"
"${PYTHON:-python3}" -m venv "$YB_THIRDPARTY_DIR/venv"
fi
set +u
# shellcheck disable=SC1090
Expand Down

0 comments on commit fd95460

Please sign in to comment.