Fix for : "[YCQL] YCQLSH - module 're' has no attribute 'sre_parse' -… #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#16780, DB-6134
Description:
Appears to be something specific with Python's synchronizing regex engine (SRE). Works fine with Python 3.10.
There has been a change in
remodule in Python 3.11. As we can see heresre_compile,sre_constantsandsre_parseare now deprecated.Changes done are according to this commit on upstream code. This commit removes the use of sre_constants, sre_parse and sre_complie for Python 3.11+ and uses
re._constants,re._parserandre._compilerinstead.Testing:
Did local testing, was able to connect to YCQLSH on Python 3.11 with this fix.
Also Tested on Python 2.7, Python 3.6, Python 3.8 and Python 3.10