Branch awareness #35
Merged
Branch awareness #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svarnau
reviewed
Oct 5, 2020
| @@ -47,7 +71,7 @@ jobs: | |||
| git add ./stable/yugabyte/Chart.yaml ./stable/yugaware/Chart.yaml \ | |||
| ./stable/yugabyte/values.yaml ./stable/yugaware/values.yaml ./stable/yugabyte/app-readme.md | |||
| git commit -m "Update the version to ${{steps.extract-version.outputs.yb_version}}" | |||
| git push origin ${{ github.ref }} | |||
| git push | |||
There was a problem hiding this comment.
To be specific, maybe: git push origin HEAD
| @@ -3,12 +3,15 @@ on: | |||
| repository_dispatch: | |||
| types: | |||
| - update-on-release | |||
| env: | |||
| CURRENT_STABLE: 2.3 | |||
There was a problem hiding this comment.
As discussed, I think I prefer if the dispatcher side send parameter is_master, based on content of version.txt on master branch on that side.
| run: | | ||
| rel=${{steps.extract-version.outputs.yb_version}} | ||
| a=( ${rel//./ } ) | ||
| branch_name="${a[0]}.${a[1]}" |
There was a problem hiding this comment.
Come to think of it, maybe we should do this calculation on dispatcher side and send a branch_name parameter? Then we won't need the is_master parameter, we just get teh branch name from yugabyte-db side.
There was a problem hiding this comment.
If we do this, lets call it yb_release or maybe yb_release_train or release_train rather than branch.
jharveysmith
force-pushed
the
branch_awareness
branch
from
d125aff to
e10a81b
Compare
svarnau
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates separate branches for each release series (2.1, 2.2, etc).
Not sure how this will play with the helm repo site. I'll have an alternative approaching using release directories in master branch shortly.