Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Storage cleard #118

Closed
goyamamoto opened this issue Aug 27, 2016 · 0 comments
Closed

Local Storage cleard #118

goyamamoto opened this issue Aug 27, 2016 · 0 comments

Comments

@goyamamoto
Copy link

It seems gotty.jp clears Local Storage on the browser.
https://github.com/yudai/gotty/blob/master/resources/gotty.js#L20
Is there any reason to do so?

I am using Gotty over a reverse proxy with a multi-factor authentication.
For my case the authentication uses Local Storage, so clearing Local Storage causes problems.

I have commented out the line, and so far it looks working fine.

@yudai yudai added the kind/bug label Aug 8, 2017
@yudai yudai added this to the v2.0.0 milestone Aug 8, 2017
@yudai yudai modified the milestones: v1.0.1, v2.0.0 Aug 8, 2017
yudai added a commit that referenced this issue Aug 8, 2017
@yudai yudai closed this as completed in #157 Aug 8, 2017
yudai added a commit that referenced this issue Aug 8, 2017
yudai added a commit that referenced this issue Aug 8, 2017
This release is bug fixes.

Fixes
-----

* #118: gotty.js clears browser's Local Storage
* #122: Configuration via environment variables doesn't work except GOTTY_CONFIGklllll
* #136: max-connections reporting wrong count
yudai added a commit that referenced this issue Aug 8, 2017
This release is bug fixes.

Fixes
-----

* #118: gotty.js clears browser's Local Storage
* #122: Configuration via environment variables doesn't work except GOTTY_CONFIGklllll
* #136: max-connections reporting wrong count
yudai added a commit that referenced this issue Aug 8, 2017
This release is bug fixes.

Fixes
-----

* #118: gotty.js clears browser's Local Storage
* #122: Configuration via environment variables doesn't work except GOTTY_CONFIGklllll
* #136: max-connections reporting wrong count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants