Add CNAME handling #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of FTL v5.2 (pi-hole/FTL#832), pihole starts logging of the actual blocked domain during deep CNAME inspection. Additionally to the requested domain (e.g.
site1.com) it stores the blocked deep CNAME domain (e.g.badsite.com) in the query table inadditional_infocolumn.This info can now be used to attribute the domain from
additional_infoto the individual adlists.This will improve the accuracy of the prediction ("usefulness") of adlists, although this prediction is limited: pihole does not store the whole CNAME chain for all domains but only for those which have been blocked.