chore(Queries): add query suggestion config [YTFRONT-4612]

ytsaurus · Feb 7, 2025 · d2927d6 · d2927d6
1 parent 066de49
commit d2927d6
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 3 deletions.
diff --git a/packages/ui/src/shared/constants/settings-types.ts b/packages/ui/src/shared/constants/settings-types.ts
@@ -83,6 +83,7 @@ interface QueryTrackerSettings {
     'global::queryTracker::queriesListSidebarVisibilityMode': boolean;
     'global::queryTracker::history::Columns': string[];
     'global::queryTracker::useNewGraphView': boolean;
+    'global::queryTracker::suggestions': boolean;
 }
 
 interface ChytSettings {

diff --git a/packages/ui/src/shared/yt-types.d.ts b/packages/ui/src/shared/yt-types.d.ts
@@ -307,6 +307,7 @@ export interface ConfigData {
     allowUserColumnPresets?: boolean;
     odinPageEnabled: boolean;
     allowTabletErrorsAPI: boolean;
+    querySuggestions?: boolean;
 }
 
 export type PipelineParams = {

diff --git a/packages/ui/src/ui/containers/SettingsPanel/settings-description.tsx b/packages/ui/src/ui/containers/SettingsPanel/settings-description.tsx
@@ -26,7 +26,7 @@ import infoIcon from '../../assets/img/svg/info-icon.svg';
 import LogoGitlabIcon from '@gravity-ui/icons/svgs/logo-gitlab.svg';
 import {useClusterFromLocation} from '../../hooks/use-cluster';
 import {docsUrl} from '../../config/index';
-import {uiSettings} from '../../config/ui-settings';
+import {getConfigData, uiSettings} from '../../config/ui-settings';
 
 import ypath from '../../common/thor/ypath';
 
@@ -95,6 +95,7 @@ function useSettings(cluster: string, isAdmin: boolean): Array<SettingsPage> {
     const vcsConfig = useSelector(selectVcsConfig);
     const isVcsVisible = useSelector(selectIsVcsVisible);
     const defaultUserACO = useSelector(getDefaultQueryACO);
+    const hasQuerySuggestions = getConfigData().querySuggestions;
 
     return compact_([
         makePage('General', generalIcon, [
@@ -571,6 +572,19 @@ function useSettings(cluster: string, isAdmin: boolean): Array<SettingsPage> {
                         oneLine
                     />,
                 ),
+                ...(hasQuerySuggestions
+                    ? [
+                          makeItem(
+                              'Use query suggestions',
+                              'top',
+                              <BooleanSettingItem
+                                  settingKey="global::queryTracker::suggestions"
+                                  description="Enable query assistant suggestions"
+                                  oneLine
+                              />,
+                          ),
+                      ]
+                    : []),
             ]),
         ),
 

diff --git a/packages/ui/src/ui/pages/query-tracker/querySuggestionsModule/createInlineSuggestions.ts b/packages/ui/src/ui/pages/query-tracker/querySuggestionsModule/createInlineSuggestions.ts
@@ -15,7 +15,7 @@ import {
     selectQuerySuggestionsContextId,
 } from '../module/querySuggestions/selectors';
 import {AcceptedTelemetryData} from '../../../../shared/suggestApi';
-import {getQuerySuggestionsEnabled} from '../../../store/selectors/settings/settings-ts';
+import {getQuerySuggestionsEnabled} from '../../../store/selectors/settings/settings-queries';
 
 const debouncedGetSuggestions = debounce_(getQuerySuggestions, 200);
 const store = getWindowStore();

diff --git a/packages/ui/src/ui/pages/query-tracker/querySuggestionsModule/useMonacoQuerySuggestions.ts b/packages/ui/src/ui/pages/query-tracker/querySuggestionsModule/useMonacoQuerySuggestions.ts
@@ -7,7 +7,7 @@ import {
 import {sendQuerySuggestionsTelemetry} from './api';
 import {useDispatch, useSelector} from 'react-redux';
 import {DiscardedTelemetryData, QuerySuggestTelemetryData} from '../../../../shared/suggestApi';
-import {getQuerySuggestionsEnabled} from '../../../store/selectors/settings/settings-ts';
+import {getQuerySuggestionsEnabled} from '../../../store/selectors/settings/settings-queries';
 import {setPrevAction} from '../module/querySuggestions/querySuggestionsSlice';
 
 export const useMonacoQuerySuggestions = (editor?: monaco.editor.IStandaloneCodeEditor) => {

diff --git a/packages/ui/src/ui/store/selectors/settings/settings-queries.ts b/packages/ui/src/ui/store/selectors/settings/settings-queries.ts
@@ -0,0 +1,7 @@
+import {createSelector} from 'reselect';
+import {getSettingsData} from './settings-base';
+import {getConfigData} from '../../../config/ui-settings';
+
+export const getQuerySuggestionsEnabled = createSelector(getSettingsData, (data) => {
+    return getConfigData().querySuggestions && (data['global::queryTracker::suggestions'] || false);
+});