Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple update selectors #383

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add multiple update selectors #383

wants to merge 4 commits into from

Conversation

wilwell
Copy link
Contributor

@wilwell wilwell commented Nov 4, 2024

No description provided.

@wilwell wilwell force-pushed the wilwell/multiple-update-selectors branch 2 times, most recently from 3be85ec to e9c2100 Compare November 5, 2024 12:08
l0kix2
l0kix2 reviewed Nov 8, 2024
View reviewed changes
controllers/sync.go Outdated Show resolved Hide resolved
@wilwell wilwell force-pushed the wilwell/multiple-update-selectors branch 6 times, most recently from ae5affa to fae9001 Compare December 5, 2024 11:50
@wilwell wilwell force-pushed the wilwell/multiple-update-selectors branch 5 times, most recently from a6175c8 to 06fd1a8 Compare December 16, 2024 13:56
@l0kix2
Copy link
Collaborator

l0kix2 commented Dec 18, 2024

Please rebase on the main branch since #387 is merged — which have couple of new stages in the flows

@l0kix2 l0kix2 mentioned this pull request Dec 18, 2024
Open
l0kix2
l0kix2 requested changes Dec 18, 2024
View reviewed changes
api/v1/ytsaurus_types.go Show resolved Hide resolved
api/v1/ytsaurus_types.go Outdated Show resolved Hide resolved
api/v1/ytsaurus_types.go Outdated Show resolved Hide resolved
pkg/consts/types.go Outdated Show resolved Hide resolved
controllers/sync.go Outdated Show resolved Hide resolved
@wilwell wilwell force-pushed the wilwell/multiple-update-selectors branch 6 times, most recently from 39016b9 to 683a5b9 Compare December 18, 2024 23:05
@wilwell wilwell force-pushed the wilwell/multiple-update-selectors branch from 683a5b9 to e9c82c1 Compare February 5, 2025 12:54
@wilwell wilwell requested a review from l0kix2 February 5, 2025 14:03
@wilwell wilwell marked this pull request as ready for review February 5, 2025 14:03
l0kix2
l0kix2 approved these changes Feb 5, 2025
View reviewed changes
pkg/consts/types.go Outdated Show resolved Hide resolved
api/v1/ytsaurus_types.go Outdated Show resolved Hide resolved
api/v1/ytsaurus_types.go Outdated Show resolved Hide resolved
@wilwell
Copy link
Contributor Author

wilwell commented Feb 6, 2025

I've added e2e test. Please review it. We have two unanswered questions

  1. Do we wnat to rename Group to Class?
  2. Is it ok to use Name in a such way? Or want shorter variant. In this case we need to agree waht to do with default empty names.

@wilwell wilwell requested a review from l0kix2 February 6, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0kix2 l0kix2 Awaiting requested review from l0kix2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilwell @l0kix2