Init job creates from InstanceSpec image if specified #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwell
changed the title
|
cc @l0kix2 |
l0kix2
requested changes
Sep 11, 2024
l0kix2
requested changes
Sep 12, 2024
pkg/components/helpers.go
Outdated
| @@ -227,3 +227,10 @@ func AddInitContainersToPodSpec(initContainers []string, podSpec *corev1.PodSpec | |||
| podSpec.InitContainers = append(containers, podSpec.InitContainers...) | |||
| return nil | |||
| } | |||
|
|
|||
| func SelectTrueImage(coreImage string, instanceImage *string) string { | |||
There was a problem hiding this comment.
suppose it can be non-exported since we are using it in the components package only
There was a problem hiding this comment.
And the name TrueImage sounds like some soft for windows. Let's maybe call It SelectEffectiveImage.
Also, I would expect a signature like getImageWithDefault(componentImage, defaultImage string)
l0kix2
approved these changes
Sep 12, 2024
|
I've realized that there is an issue with this change since all jobs require yt cli installed, but strawberry and UI have different images which can't be used for k8s job. I'll fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change if resource(master/chyt/scheduler etc.) is updated the init job still uses outdated image from
Spec.CoreImage.This change corrects this behavior, and if the more relevant image exists it gonna be used instead (relevant image for each resource)
Closes #157