Fixed youtube code due to recent changes in the site #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youtube no longer provides www.youtube.com/get_video interface and responds on these requests with HTTP 204 No Content. Native youtube flashplayer gets HTTP 204 code as well. Video url is now extracted from fmt_map variable.
|
Won't merge this exact code. This crashes if the user requests, using -f, a format which is not in the format list. |
|
True. Glad to help anyway. |
|
Your code was indeed invaluable in getting this fixed pretty fast. Thanks a lot for taking the time to analyze the problem and providing a solution I just had to modify slightly. |
This was referenced Oct 18, 2014
Closed
joedborg
referenced
this pull request
in joedborg/youtube-dl
Nov 17, 2020
[pull] master from rg3:master
tsukumijima
pushed a commit
to tsukumijima/youtube-dl
that referenced
this pull request
Dec 2, 2020
Fixed problem with JS player URL
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Youtube no longer provides www.youtube.com/get_video interface and responds on these requests with HTTP 204 No Content. Native youtube flashplayer gets HTTP 204 code as well.
Video url is now extracted from fmt_map variable.