[pornhub] Download archive improvement #31432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkf
requested changes
Jan 9, 2023
dirkf
reviewed
Feb 9, 2023
Comment on lines
+521
to
+523
| PornHubIE.ie_key(), video_title=title, video_id=id) | ||
| for video_url, id, title in orderedSet(re.findall( | ||
| r'href="/?(view_video\.php\?.*\bviewkey=([\da-z]+)[^"]*)"[^>]*\s+title="([^"]+)"', |
There was a problem hiding this comment.
Actually, if extracting the ID, that's the primary key on which we should be filtering.
seen_ids = set()
for m in re.finditer(
r'href="/?(view_video\.php\?.*\bviewkey=([\da-z]+)[^"]*)"[^>]*\s+title="([^"]+)"',
container):
v_url, v_id, title = m.group(1, 2, 3)
if v_id in seen_ids:
continue
yield self.url_result(
'http://www.%s/%s' % (host, v_url),
PornHubIE.ie_key(), video_title=title, video_id=v_id)
seen_ids.add(v_id)Anyhow, avoid a variable id since that has a specific meaning in Python.
Suggested change
| PornHubIE.ie_key(), video_title=title, video_id=id) | |
| for video_url, id, title in orderedSet(re.findall( | |
| r'href="/?(view_video\.php\?.*\bviewkey=([\da-z]+)[^"]*)"[^>]*\s+title="([^"]+)"', | |
| PornHubIE.ie_key(), video_title=title, video_id=v_id) | |
| for video_url, v_id, title in orderedSet(re.findall( | |
| r'href="/?(view_video\.php\?.*\bviewkey=([\da-z]+)[^"]*)"[^>]*\s+title="([^"]+)"', |
Also, the question as to why orderedSet(), which is de-duplicated but not sorted, got its name arises ...
dirkf
added a commit
that referenced
this pull request
Oct 14, 2024
Thx: * MrBigDig <mrbigdig2020@gmail.com> * yt-dlp contributors. Supersedes, closes #31432.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
PornHub video metadata is downloaded while downloading playlist even though video id is present in archive file.
This happens because PornoHub playlist extractor doesn't extract video id and video id is needed to check presence in archive. With video id exported downloading new videos from playlists happens faster.
Example (before):
First attempt downloads metadata and video. Second attempt downloads only metadata.
Example (after):