Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/ceskatelevize] Back-port extractor from yt-dlp, etc #30713

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

dirkf
Copy link
Contributor

@dirkf dirkf commented Mar 4, 2022

Please follow the guide below


Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense, except for code acquired from yt-dlp for which either this or the below was previously asserted
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This PR back-ports the CeskaTelevize yt-dlp extractor, removing CeskaTelevizePoradyIE. An interim traverse_obj() shim is used. The existing tests have been fixed and/or new ones added as needed.

The following additional changes were made:

  • follow redirect URL
  • support liveBroadcast and videobonusDetail in __NEXT__ data
  • id must be compat_str
  • return single video for singleton playlist.

Resolves #30151
Resolves #30166
Resolves #30172
Resolves #30406
Resolves #30696
Expected to resolve #29415.

* back-port extractor with traverse_obj() shim, removing CeskaTelevizePoradyIE
* follow redirect URL
* support liveBroadcast and videobonusDetail in __NEXT__ data
* id must be compat_str
* return single video for singleton playlist
* fix/add tests
@dirkf dirkf merged commit de39d12 into ytdl-org:master Nov 4, 2022
gaming-hacker added a commit to gaming-hacker/youtube-dl that referenced this pull request Nov 4, 2022
* commit 'de39d1281cea499cb1adfce5ff7e0a56f1bad5fe':
  [extractor/ceskatelevize] Back-port extractor from yt-dlp, etc (ytdl-org#30713)
  [utils] Backport traverse_obj (etc) from yt-dlp (ytdl-org#31156)
  [compat] Work around in case folding for narrow Python build
  [compat] Add test for compat_casefold()
  [compat] Add test for compat_casefold()
  [compat] Reformat casefold.py for easier updating
  [compat] Unify unicode/str compat and move up
  [compat] Add compat_casefold and compat_re_Match, for traverse_obj() port
  [compat] Add Python 2 Unicode casefold using a trivial wrapper around icu/CaseFolding.txt
  [netease] Support urls shared from mobile app (ytdl-org#31304)
  [netease] Impove error handling (ytdl-org#31303)
  [Vimeo] Update variable name in hydration JSON pattern

# Conflicts:
#	youtube_dl/extractor/ceskatelevize.py
github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Nov 4, 2022
* https://github.com/ytdl-org/youtube-dl:
  [extractor/ceskatelevize] Back-port extractor from yt-dlp, etc (ytdl-org#30713)
alxlive pushed a commit to alxlive/youtube-dl that referenced this pull request Feb 27, 2023
…org#30713)

* back-port extractor, removing CeskaTelevizePoradyIE
* follow redirect URL
* support liveBroadcast and videobonusDetail in __NEXT__ data
* return single video for singleton playlist
* fix/add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment