Initial implementation of SOCKS4/SOCKS5 support #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
youtube-dl is released to the public domain. This module would introduce a dependency on MIT-licensed sources. |
|
Got it, fair enough. I'll close this pull request then. |
Closed
|
I've written an public domain socks wrapper for python: |
Closed
joedborg
referenced
this pull request
in joedborg/youtube-dl
Nov 17, 2020
[pull] master from ytdl-org:master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I hacked together support for SOCKS proxies using some code I found (https://gist.github.com/869791). It works for me, but I haven't tested it any more than that (yet).
How do you feel about putting this back into master? There's a few problems right now, mainly that the socks code is in separate files (and they're not tiny, ~400 lines), so it breaks the nice, clean "download this script and run it" experience.
Let me know what you think. Cheers!
Matt