Implementing thumbnails formats selection #28752
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Responding to this feature req:
#28726
Trying to add a --thumbnail-format option, that allows the user to choose which of the available thumbnails to download.
It takes the ID (as reported with the --list-thumbnails options) as input, and falls back to the default one (last element of the thumbnails dictionary) if the ID is invalid.
Not sure if it's the best idea to use a separate option like I did, or if it would be better to collapse everything into --write-thumbnail, though I'd be afraid to break existing scripts. Glad to get input on this - well, or any input in general :-)
Pardon the multiple commits.
Usage example:
python -m youtube_dl --write-thumbnail --thumbnail-format 2 https://www.youtube.com/watch?v=YQ04r4HGS-U