Uploaddate for YoutubeIE #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'll merge. :) |
ghost
mentioned this pull request
Closed
6 tasks
6 tasks
joedborg
referenced
this pull request
in joedborg/youtube-dl
Nov 17, 2020
[pull] master from rg3:master
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here's an implementation of the uploaddate output sequence for YoutubeIE. I have some concerns though.
So far I've seen two date formats for Youtube, eg. "November 17, 2010" and "17 November 2010". I can't seem to figure out which one is used when. For now I've only added those two but I can write some extra code that will systematically try all possible format expressions until a match is found. I don't think that's efficient or necessary at this stage.
I also had a line that normalises the date by removing [/-,] and replacing them with spaces, so that format_expressions would always be of the form "%x %y %z".
Let me know your thoughts.
Regards,
Nevar.