Print traceback when raising UnavailableVideoError #10888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An OSError or IOError generally indicates something a little more wrong than a "simple" UnavailableVideoError, so print the actual traceback that leads to the exception. Otherwise meaningful postmortem debugging a bug report is essentially infeasible.
|
Exception handling in youtube-dl is quite messy... The best way to fix this is exploiting Python 3's exception chaining. [1] python-future [2] provides A possible short term fix is introducing the Anyway the traceback should NOT be printed to stderr directly. Use [1] https://www.python.org/dev/peps/pep-3134/ |
johnhawkinson
referenced
this pull request
in johnhawkinson/youtube-dl
Oct 9, 2016
This reverts commit ca14b60. Moved to PR #10888.
All of the |
|
In CLI they did print to stderr, while applications that use the Python API may intercept them using |
|
Huh? It's clear they go to stderr in youtube-dl. Are you saying you still want me to do ? |
Only when
Yes, just without the first underscore (_self => self) |
Per @yan12125, traceback.print_exc() can send output to the wrong place under some circumstances (e.g. use of logger), so send it to stderr. Which requires a compat_str.
|
OK, thanks, done! |
yan12125
approved these changes
Oct 9, 2016
|
Hmm the first exception is not shown with this patch. Anything wrong? |
Err, it works for me. Did you mean to run it out of the build tree instead of the instead of ? I get: Ah yes, your run was:
|
|
I apply this patch with a commit, so the commit ID does not change. Let me check it out more. |
|
Looks like a python3 issue. You confused me when you wrote:
But python3 shows the inner traceback but not the outer one, but I think that's the more useful one to show. So it looks like this patch is only relevant for python2. Still worth doing though. |
|
Hello! what is needed to get this and #10876 merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An OSError or IOError generally indicates something a little more
wrong than a "simple" UnavailableVideoError, so print the actual
traceback that leads to the exception. Otherwise meaningful postmortem
debugging from a bug report is essentially infeasible.
Forked this pull request from #10876 (Fix UnavailableVideoError when writing to pipes) as requested by @yan12125.