MNT: housekeeping #3951
Merged
MNT: housekeeping #3951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
housekeeping
branch
4 times, most recently
from
06f3980 to
87fa0e3
Compare
matthewturk
previously approved these changes
Jun 2, 2022
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [build-system] | |||
| requires = [ | |||
| "setuptools>=19.6", | |||
| "setuptools>=59.0.0", | |||
There was a problem hiding this comment.
I guess it's been a while since we updated this requirement, eh?
There was a problem hiding this comment.
Yep, 19.6 probably doesn't actually work anymore actually
There was a problem hiding this comment.
for posterity: setuptools 19.6 only supported Python <= 3.5, so it's clearly not viable anymore
https://pypi.org/project/setuptools/19.6/
There was a problem hiding this comment.
just noticed that 59.0.0 wasn't available anymore so moving to 59.0.1 to avoid confusion in case we ever want to make it a strict pin
|
|
||
| log = logging.getLogger("setupext") |
There was a problem hiding this comment.
should we explicitly note that this is yt's setupext?
There was a problem hiding this comment.
I don't think there's any risk of collisions so I guess not ?
neutrinoceros
force-pushed
the
housekeeping
branch
from
87fa0e3 to
6fb57c7
Compare
matthewturk
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
toml-typesdep (not needed since MNT: migrate from toml to tomli + tomli_w #3831)conftest.py(the simple fact that test pass validate that we don't need it anymore)loggingis the official recommended replacement fordisutils.logsourcedistutils.errorsis re-exported withinsetuptools.errorssincesetuptools 59.0.0(see Re-exporterrorsfromdistutilspypa/setuptools#2858)setuptoolsfrom runtime dependency (this is a left over from an old misunderstanding: setuptools was in fact never a runtime dependency)