Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounded corner for new backends #658

Closed
wants to merge 8 commits into from
Closed

Rounded corner for new backends #658

wants to merge 8 commits into from

Conversation

yshui
Copy link
Owner

@yshui yshui commented Jul 16, 2021 •
edited
Loading

TODOs:

  • Corner radius API change
  • Rounded corner
    • GLX
    • xrender
  • Clip shadows properly for rounded windows
    • GLX
    • xrender
  • Rounded border
    • GLX
    • xrender

@codecov
Copy link

codecov bot commented Jul 16, 2021 •
edited
Loading

Codecov Report

Merging #658 (d397b30) into next (ad18d12) will decrease coverage by 0.00%.
The diff coverage is 57.14%.

❗ Current head d397b30 differs from pull request most recent head da909b7. Consider uploading reports for the commit da909b7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next     #658      +/-   ##
==========================================
- Coverage   39.31%   39.31%   -0.01%     
==========================================
  Files          46       46              
  Lines        9584     9590       +6     
==========================================
+ Hits         3768     3770       +2     
- Misses       5816     5820       +4
Impacted Files Coverage Δ
src/backend/backend_common.c 40.08% <0.00%> (-0.17%) ⬇️
src/backend/gl/gl_common.h 23.07% <ø> (ø)
src/options.c 21.47% <ø> (+0.12%) ⬆️
src/backend/gl/gl_common.c 15.10% <50.00%> (+0.14%) ⬆️
src/backend/backend.c 63.80% <100.00%> (+0.44%) ⬆️
src/picom.c 67.59% <0.00%> (-0.16%) ⬇️
src/win.c 68.03% <0.00%> (-0.10%) ⬇️

@tryone144 tryone144 mentioned this pull request Jul 17, 2021
Closed
@tryone144 tryone144 mentioned this pull request Aug 18, 2021
Closed
yshui added 2 commits October 23, 2021 12:21
@yshui
backend: add new image property: corner radius
de31cd4 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui
backend: gl_common: handle corner radius property
1fec938 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui yshui force-pushed the new-backend-rounded-corner branch from 4155231 to 1fec938 Compare October 23, 2021 11:22
yshui added 4 commits October 23, 2021 12:53
@yshui
options: don't disable rounded corner for new backends
6d72bf2 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui
backend: set corner radius property
d397b30 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui
backend: xrender: handle corner radius
76db8cc 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui
backend: xrender: cache rounded rectangle mask
1dea294 
xcb_render_triangle is slow because (at least for Glamor) it's
rasterizing the triangles on CPU.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui yshui mentioned this pull request Oct 28, 2021
Merged
@yshui yshui mentioned this pull request Nov 5, 2021
Closed
yshui added 2 commits November 8, 2021 00:19
@yshui
backend: xrender: fix accidentally deleta refcount decrement
a078b2f 
Thanks, @tryone144

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui
backend: explicitly initialize corner_radius
da909b7 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@dccsillag dccsillag mentioned this pull request Nov 8, 2021
Closed
@tryone144 tryone144 mentioned this pull request Nov 20, 2021
Closed
@brongulus brongulus mentioned this pull request Dec 8, 2021
Closed
@yshui yshui closed this Feb 5, 2022
@Blakeinstein
Copy link

Why was this closed?

@yshui
Copy link
Owner Author

yshui commented Feb 5, 2022

@Blakeinstein because it has been implemented

@Blakeinstein
Copy link

Blakeinstein commented Feb 5, 2022 •
edited
Loading

@Blakeinstein because it has been implemented

I am dumb, I was looking at tryone's PR. apologies.

on an additional note, maybe merge pr's linking issues? hard to see if you dont resolve an issue with a pr. (could be my ocd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yshui @Blakeinstein