Universal window rules #1297
Merged
Universal window rules #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshui
force-pushed
the
universal-rules
branch
3 times, most recently
from
84065fc
to
f3bd17e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1297 +/- ##
=======================================
Coverage ? 52.43%
=======================================
Files ? 64
Lines ? 14005
Branches ? 0
=======================================
Hits ? 7344
Misses ? 6661
Partials ? 0
|
yshui
force-pushed
the
universal-rules
branch
16 times, most recently
from
053913f
to
3d62eba
Compare
|
maybe it's a good idea to rewrite the sample config to use the |
yshui
force-pushed
the
universal-rules
branch
3 times, most recently
from
736db11
to
fe72b79
Compare
It's easier to just store them together, since the same group of information is needed for parsed window rules, and for window rendering. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Opacity was calculated once per mapped window per frame in `win_process_animation_and_state_change`. This is fine because calucating it is cheap. However with upcoming changes it might become more expensive. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
It's only used as an intermediate value for calculating other window options, and is not used outside `win_on_factor_changed`, so there is no reason to save it. This also removes the "focused_force" option from the dbus interface, which I believe nobody is using anyways. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Instead of just a yes or no. Allow for more flexibility when universal rules are implemented. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
From the user's perspective they are just random, meaningless numbers. Doesn't really make sense to write rule against them. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Instead of recalculate every window's leader each time one of the window's leader changed, aggregate all the changes and update all the leaders in one go. And now all the calculations are in one place too (wm/wm.c). Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
This matches when the focused window is in the same window group as the window being matched. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Design is described in #1284. Added a trivial test of universal rules Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
To replace wintypes::redir_ignore as well as unredir-if-possible-exclude. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
This includes updating the changelog. Closes #1284 Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Co-authored-by: Maxim Solovyov <msolovyov@protonmail.com> Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
When implementing animation, which also replaced the old fading code, the per-window fading option was accidentally broken. This commit brings it back. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Removed old options that are no long relevant (though not deprecated). Converted all old rules to the new `rules` option. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1284