backend: xrender: cache the present region #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## stable/11 #1167 +/- ##
=============================================
- Coverage 36.66% 36.46% -0.20%
=============================================
Files 50 50
Lines 11497 11516 +19
=============================================
- Hits 4215 4199 -16
- Misses 7282 7317 +35
|
|
huh, it seems that my clang-format formats code differently 🤔 |
absolutelynothelix
force-pushed
the
xrender-cache-present-region
branch
from
9b9804d
to
72e9dd5
Compare
|
@absolutelynothelix hi, can you change the target branch to |
it sets an x region to a pixman region
to avoid creating and destroying it every frame
absolutelynothelix
force-pushed
the
xrender-cache-present-region
branch
from
72e9dd5
to
5a1990b
Compare
|
There is a bit of code duplication but since this is a temporary fix I think it's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a workaround for #1166. it doesn't fix the underlying issue (that's not known and needs to be investigated and ideally fixed) but reduces the probability of it's appearance. lmk if i got too paranoid with various checks and some of them are not really needed 😅
x: add the x_set_region function
it sets an x region to a pixman region
backend: xrender: cache the present region
to avoid creating and destroying it every frame