fix:uploader组件增加单张只读属性 #3270
Merged
fix:uploader组件增加单张只读属性 #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uploader组件，deletable属性只能控制全局是否可以删除，不能控制单张图片是否可删除，因此当fileList内为对象时，增加onlyRead标识，当onlyRead为true时，单张不显示删除icon;
uploader组件，deletable属性只能控制全局是否可以删除，不能控制单张图片是否可删除，因此当fileList内为对象时，增加onlyRead标识，当onlyRead为true时，单张不显示删除icon;
refactor:uoloader组件增加单张只读属性
|
是否有必要添加这个功能？我觉的没有，不让删除的图片不用这包裹就好了，感觉需求不大。 |
可能业务情况不同吧，我们的需求是服务端默认显示的图片或者上一次上传的图片，在回显详情的时候不让删除，但可以继续添加新图片，新图片是可以删除的，为了UI一致性和美观，不让删除的和可以删除的都用了uploader包裹，这样全局的是否可删除属性就不够用了。 |
chenjiahan
reviewed
Jun 11, 2020
packages/uploader/index.wxml
Outdated
| @@ -38,7 +38,7 @@ | |||
| <text wx:if="{{ item.message }}" class="van-uploader__upload-text">{{ item.message }}</text> | |||
| </view> | |||
| <view | |||
| wx:if="{{ deletable }}" | |||
| wx:if="{{ deletable && !item.onlyRead }}" | |||
There was a problem hiding this comment.
推荐命名为 item.deletable，并补充到文档中
|
修改内容： |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uploader组件，deletable属性只能控制全局是否可以删除，不能控制单张图片是否可删除；因此当fileList内为对象时，增加onlyRead标识，当onlyRead为true时，单张不显示删除icon。