Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dynamo conditions to include name in AttributeBase #230

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

fivepapertigers
Copy link
Contributor

Notes

Addes the name property to the AttributeBase class (and subclasses)

Addresses #229

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

All of these are optional:

  • I have performed a self-review of my own code
  • I have run ./scripts/before_commit.sh to follow the style guidelines of this project
  • I have tested my code changes

Thank you!

@vemel
Copy link
Collaborator

vemel commented Oct 27, 2023

Thank you for your contribution! Probably it makes sense to do smth like:

class AttributeBase:
    def __init__(self, name: str) -> None:
        self.name: str

because AttributeBase.name is not a class attribute. Let me know what you think!

@vemel vemel added the 👋 response needed Awaiting response from a reporter label Oct 27, 2023
@vemel vemel self-requested a review October 27, 2023 21:16
Copy link
Collaborator

@vemel vemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move name attribute to __init__ method

@vemel vemel merged commit 1e702f8 into youtype:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👋 response needed Awaiting response from a reporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants