Fix the issue of reserving string capacity with invalid size #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue caused the app to crash when a network error is encountered and content_length is -1. Also added checks for the bytes size for the Write() function. b/394975919 Change-Id: I2d8cbf63680781704c60f8e8702ccfcff751a7fc
jellefoks
approved these changes
Feb 13, 2025
yuying-y
added a commit
to yuying-y/cobalt
that referenced
this pull request
Feb 14, 2025
…ty with invalid size This issue caused the app to crash when a network error is encountered and the content_length used for reserving string capacity is -1. Also added checks for the bytes size for the Write() function. Verified the fix on Linux. This is a manual cherry-pick from youtube#4910, since adding the label cp-24.lts.1+ on Github didn't create the cherry-pick CL automatically. b/394975919 Change-Id: I9a05ade9d9bb5a83943fb5239ac43d9c1d60ead8
yuying-y
added a commit
to yuying-y/cobalt
that referenced
this pull request
Feb 14, 2025
…ty with invalid size This issue caused the app to crash when a network error is encountered and the content_length used for reserving string capacity is -1. Also added checks for the bytes size for the Write() function. Verified the fix on Linux. This is a manual cherry-pick from youtube#4910, since adding the label cp-24.lts.1+ on Github didn't create the cherry-pick CL automatically. b/394975919 Change-Id: I9a05ade9d9bb5a83943fb5239ac43d9c1d60ead8
oxve
pushed a commit
that referenced
this pull request
Feb 14, 2025
#4914) … invalid size This issue caused the app to crash when a network error is encountered and the content_length used for reserving string capacity is -1. Also added checks for the bytes size for the Write() function. Verified the fix on Linux. This is a manual cherry-pick from #4910, since adding the label cp-24.lts.1+ on Github didn't create the cherry-pick CL automatically. b/394975919 Change-Id: I9a05ade9d9bb5a83943fb5239ac43d9c1d60ead8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue caused the app to crash when a network error is encountered and the content_length used for reserving string capacity is -1. Also added checks for the bytes size for the Write() function. Verified the fix on Linux.
b/394975919
Change-Id: I2d8cbf63680781704c60f8e8702ccfcff751a7fc