Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILD_STATUS.md to Chrobalt. #4192

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Add BUILD_STATUS.md to Chrobalt. #4192

merged 8 commits into from
Oct 3, 2024

Conversation

briantting
Copy link
Contributor

No description provided.

@briantting briantting requested a review from a team as a code owner October 2, 2024 23:04
BUILD_STATUS.md Outdated Show resolved Hide resolved
@briantting briantting requested a review from oxve October 2, 2024 23:33
BUILD_STATUS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dahlstrom-g dahlstrom-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions about this PR:

BUILD_STATUS.md Outdated Show resolved Hide resolved
@oxve
Copy link
Contributor

oxve commented Oct 3, 2024

A few questions about this PR:

  • Do we have to add this file in the root?

It should live under /chrobalt.

We're building very different things now. See my comment earlier on the PR.

  • Isn't it unhygienic to name various branches in a file on the main branch?

This is the overall build status, it should show all the important builds in one place.

@briantting
Copy link
Contributor Author

A few questions about this PR:

Added to Chrobalt instead, because added 25 lts and cleaned up main which only does linux and android now, we want this to be a singular status page to monitor everything so kinda but for ease of use its necessary and what we were doing before, because when i hit edit within github thats what happens (its 8 now)

@briantting briantting merged commit 906ad8e into youtube:main Oct 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants