starboard/types.h: Replace kSbInt16Min/Max with std::numeric_limits equivalents #4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yell0wd0g
changed the title
|
@y4vor PTAL - should be a trivlal CL but I wasn't 100% sure whether inlining STL was the way to go (I would say it is, considering that |
y4vor
approved these changes
Oct 1, 2024
Datadog ReportBranch report: ✅ 0 Failed, 228934 Passed, 42 Skipped, 38m 2.51s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said this CL replaces kSbInt16Min/Max with their std::numeric_limits<> equivalent, and removes kSbUInt16Max entirely because it's unused.
Verified bya local x64x11 build.
[1] https://source.corp.google.com/search?q=kSb.%3FInt(16)&sq=&ss=h%2Flbshell-internal%2Fcobalt_src%2F%2B%2Frefs%2Fheads%2FCOBALT
b/366064934