Restore recvmsg in udp_socket_posix #4151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change (PR3904) replaced recvmsg() with recvfrom unnecessarily. This change to restore the recvmsg(). b/302741384
Datadog ReportBranch report: ✅ 0 Failed, 228913 Passed, 42 Skipped, 38m 10.69s Total Time |
maxz-lab
requested review from
jellefoks and
johnxwork
and removed request for
dahlstrom-g
To make the upstream easier, the changes made in _posix files for socket API changes are clearly guarded by macro defined(STARBOARD). b/302741384
maxz-lab
force-pushed
the
maxz-sb16-missing
branch
from
005ce7a
to
f0dc5d2
Compare
jellefoks
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Thanks. Yes while this makes the Starboard difference look very involved, that kind of is the point and now it is very visible how our adaptation is different from upstream. There are probably cleanups we can do form here, but this makes that task possible with direct vision on what changes we did make.
johnxwork
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change (PR3904) replaced recvmsg() with recvfrom unnecessarily. This change to restore the recvmsg().
b/302741384