Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trunk to Starboard 17 #3884

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Conversation

madhurajayaraman
Copy link
Contributor

@madhurajayaraman madhurajayaraman commented Jul 24, 2024

b/355449840

Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - but i thought we also need to add new matching sabi json files with this ?

Change-Id: I8f08239cca6b687e54ce73f8a635cabb55c4e114
Change-Id: I630e08e7f67be728e4343450a958c5a986ccf5e4
Change-Id: I246d7e926ca669ebfcb9c40c5a8ed5a99da7635a
Change-Id: I94a90d996c5a333c4186c1714a6e1db4ef9e1c5e
Change-Id: I989a0a983c135d8237c32f06095666393060ad3a
Change-Id: I4c764d1754adcf8631aa96476acf25f390877040
Change-Id: I30a306262f8f0fc2a8177bed0e8ff5970272cf0c
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.74%. Comparing base (2de8ba1) to head (0a42ab9).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3884      +/-   ##
==========================================
- Coverage   57.75%   57.74%   -0.01%     
==========================================
  Files        1779     1770       -9     
  Lines       86573    86472     -101     
==========================================
- Hits        50001    49937      -64     
+ Misses      36572    36535      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madhurajayaraman madhurajayaraman merged commit 1f7d8a5 into youtube:main Jul 31, 2024
358 of 364 checks passed
@madhurajayaraman madhurajayaraman deleted the sb17 branch July 31, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants