Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move where performance entry's reponseEnd is recorded. #3782

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Move where performance entry's reponseEnd is recorded. #3782

merged 1 commit into from
Jul 10, 2024

Conversation

aee-google
Copy link
Contributor

b/231748800

@aee-google aee-google requested a review from a team as a code owner July 8, 2024 20:31
@aee-google aee-google requested a review from kaidokert July 9, 2024 18:47
kaidokert
kaidokert approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and thanks for amending the test too.

Please have Andrew look as well

@aee-google aee-google merged commit 8e1e3ca into youtube:main Jul 10, 2024
317 of 318 checks passed
@aee-google aee-google deleted the response-end branch July 10, 2024 18:01
@aee-google aee-google added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Jul 10, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jul 10, 2024
@aee-google @anonymous1-me
Move where performance entry's reponseEnd is recorded. (#3782)
8a70e27 
b/231748800

(cherry picked from commit 8e1e3ca)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jul 10, 2024
Merged
aee-google added a commit that referenced this pull request Jul 12, 2024
@cobalt-github-releaser-bot @aee-google
Cherry pick PR #3782: Move where performance entry's reponseEnd is re…
d4a3660 
…corded. (#3815)

Refer to the original PR: #3782

b/231748800

Co-authored-by: aee <aee@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

Assignees
No one assigned
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aee-google @kaidokert @andrewsavage1