Add ArtworkDownloader interface

[zhongqiliang]

Extract and refactor the part of the code in ArtworkLoader to a new interface ArtworkDownloader and its default implementation ArtworkDownloaderDefault, so that we could swap the implementation in Kimono to avoid GMS Extract the artwork downloading functionality from ArtworkLoader into a separate interface (ArtworkDownloader) and a default implementation
(ArtworkDownloaderDefault). This will allow the Kimono project to provide its own implementation without relying on GMS dependencies.

b/347963541

Change-Id: I7edd475991c7dd755aa24f313aaa890db4d5798d

[kaidokert]

This seems like a good way to abstract this, but have you considered generalizing CobaltHttpHelper interface instead ? So that we can swap out that implementation for all uses of java.net.URLHttpConnection with a single module ?

[datadog-cobalt-youtube]

Datadog Report

Branch report: artwork_downloader
Commit report: 23601c0
Test service: cobalt

✅ 0 Failed, 34428 Passed, 6 Skipped, 9m 15.25s Total Time

[zhongqiliang]

These are all Java changes, all failed c++ tests should be flaky.

[zhongqiliang]

The CobaltHttpHelper is a utility customized for the DRM provisioning. I do not see an easy way to combine it with the ArtworkDownloader.

The best thing I can do is to combine these 2 things into 1 interface, something like.
public interface HttpClientUtil {
public Bitmap downloadArtwork(String url);
public byte[] performDrmHttpPost(String url);
}

I felt this is probably not better than split, e.g add this interface on top of what we have
public interface DRMProvisioningUtil {
public byte[] performDrmHttpPost(String url);
}
This way, we can speed up the process to fix the GMS kill app issue on prod.

How about we submit this first, then follow up with the DRM fix in 2 weeks?

[kaidokert]

How about we submit this first, then follow up with the DRM fix in 2 weeks?

That's fine. I'd go ahead and make it a re-factor so that the CobaltHttpHelper doesn't implement specific HTTP work ( e.g. artwork or drm ) but be a general helper for making a HTTP POST or GET request, with the logic for specifying Artwork or DRM arguments and payloads in their original modules.

[xiaomings]

Just wanted to double check if we need to add this file to "apk_sources.gni".

[zhongqiliang]

Yes, we need to add the new files in the gni file, thanks for pointing this out.