Always null-check MediaCodec with synchronized Holder #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On-device tests are failing for unrelated reason, revert pending in #3598 |
kaidokert
force-pushed
the
more_sync
branch
3 times, most recently
from
fa36367
to
11fac27
Compare
Adds a simple guard getter around mMediaCodec access, to reduce chances it gets destroyed and then accessed. Note this should really be a synchronized access instead from all call sites. b/331835987
zhongqiliang
approved these changes
Jun 24, 2024
That's the intent, yes. We won't get NPE crashes, and the IllegalState will get logged. |
|
This change will convert the NPE to a IllegalStateException, we already have catch blocks for IllegalStateException, so this will reduce the exceptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps mMediaCodec in a synchronized holder class, guaranteeing synchronized access and prevents unhandled null pointer exceptions.
This is alternate implementation to #3596
b/331835987