Update base, net and dependencies #2969

andrewsavage1 · 2024-04-17T04:17:17Z

b/335357085

b/316406231

b/316406015 Note: After fixing the compiling issue, this test still fails for Error: attempt to dereference a past-the-end iterator. An this is blocked by b/312772759.

b/316404889

b/316405463

b/316404193

Test launcher is not used by Cobalt. b/316405995

b/316404199

b/316404698

b/316404703

This test currently is disabled in trunk and not used by Cobalt. b/316405823

b/316403527 b/298237650 These functions are not implemented in Starboard. And there is a Not implemented reached warning. Should be ok to directly disable these parts of the test.

b/316404127

After this change, run all base unittests should pass except the partition_allocator tests which will be later fixed by #2405. b/298237650

Co-authored-by: Igor Sarkisov <isarkisov@google.com> b/325657345

This updates base runner images to Debian11. b/291067151 b/291066320 b/312772759 b/321746394 (cherry picked from commit a37421c) Co-authored-by: Kaido Kert <kaidokert@google.com>

Change-Id: Ie6dbf402e91a7d52d98b675fa834d2c6393c7205

b/298236240

b/323994356

b/323993063

b/323994356

b/326459868

b/333907043

…c14ae64382 (#2923) Corresponds to Chromium 114.0.5735.331 b/333907043

Found a few bugs surfaced after we adopted the new base. With this PR all leaks detected at Cobalt shutdown are plugged. See each commit for details. b/333556585

b/332367155

b/333907043

b/332367155

codecov · 2024-04-17T04:25:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.91%. Comparing base (52dee1f) to head (a0827ea).
Report is 81 commits behind head on main.

❗ Current head a0827ea differs from pull request most recent head 4708bf5. Consider uploading reports for the commit 4708bf5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2969      +/-   ##
==========================================
- Coverage   59.74%   58.91%   -0.84%     
==========================================
  Files        1825     1822       -3     
  Lines       88124    88753     +629     
==========================================
- Hits        52652    52289     -363     
- Misses      35472    36464     +992

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

datadog-cobalt-youtube · 2024-04-17T04:56:01Z

Datadog Report

Branch report: feature/all-upstream-update
Commit report: 4708bf5
Test service: cobalt

✅ 0 Failed, 33988 Passed, 6 Skipped, 1h 28m 32.66s Wall Time

b/334969418

Change-Id: If07d9bc82608933369e81e62e100db63071a0958

b/333780883

b/335357085

sherryzy and others added 30 commits February 2, 2024 02:12

Fix TimeTest (#2353)

f755203

b/316406231

Fix TaskEnvironmentTest (#2371)

a9f528f

b/316406015 Note: After fixing the compiling issue, this test still fails for Error: attempt to dereference a past-the-end iterator. An this is blocked by b/312772759.

Fix platformThreadTest (#2369)

821119c

b/316404889

Fix sys_info_unittest (#2342)

ce5212d

b/316405463

Fix native_library_unittest for cobalt. (#2264)

f57d326

b/316404193

Disable test launcher unittest (#2396)

15c5dae

Test launcher is not used by Cobalt. b/316405995

Fix profiler/* unittests (#2386)

4de5bf3

b/316404199

Fix state_transitions_unittest (#2388)

4ffe61f

b/316404698

Disable sync socket unittest (#2389)

2ae9a1b

b/316404703

Disable histogram_enum_reader_unittest.cc (#2390)

e08a2d7

This test currently is disabled in trunk and not used by Cobalt. b/316405823

Fix FileProxyTest (#2241)

54e90f5

b/316403527 b/298237650 These functions are not implemented in Starboard. And there is a Not implemented reached warning. Should be ok to directly disable these parts of the test.

Enable sparse_histogram_unittest (#2424)

d314411

b/316404127

Get all targets building off of updated base/net (#2382)

86dd367

Fix gn check (#2430)

62837ec

Disable previous failed tests (#2428)

70c73cf

After this change, run all base unittests should pass except the partition_allocator tests which will be later fixed by #2405. b/298237650

Add temporary flags to evergreen config for modular builds (#2436)

02761a7

Co-authored-by: Igor Sarkisov <isarkisov@google.com> b/325657345

Change base image to Debian 11 (#2009) (#2398)

e3c5c43

This updates base runner images to Debian11. b/291067151 b/291066320 b/312772759 b/321746394 (cherry picked from commit a37421c) Co-authored-by: Kaido Kert <kaidokert@google.com>

Update //build for cobalt for updated //base.

86bdb5f

Change-Id: Ie6dbf402e91a7d52d98b675fa834d2c6393c7205

Make brotli GN labels match Chromium

60c39fe

Move dial_server to cobalt/network (#1797)

1068dca

b/298236240

Update //build for cobalt for updated //base. (#2405)

7e4ef91

b/323994356

Clean up GetAs* functions from values.h (#2464)

d682047

b/323993063

Add includes for types. (#2472)

8d032b3

b/323994356

Merge branch 'main' into work/merge

7f0ddcc

Add bug to TODO. (#2474)

05807a1

b/326459868

Catch up branch to feature/all-upstream-update

513e76c

Okay changes

61cfd44

Pretty hacky cobalt/network changes

bef528d

Other hacky changes

fbf04ba

Build gold

640d3d7

andrewsavage1 and others added 13 commits April 15, 2024 14:37

Update crypto from Chromium 114.0.5735.331 (#2920)

43be440

b/333907043

Update third_party/modp_b64 from Chromium 114.0.5735.331 (#2922)

c421a10

b/333907043

Update net/third_party/quiche/src from 02c69dd28eef7ef2618782e8d54d53…

2659603

…c14ae64382 (#2923) Corresponds to Chromium 114.0.5735.331 b/333907043

Fix all memory leaks in Cobalt and layout_tests shutdown (#2940)

2d891e8

Found a few bugs surfaced after we adopted the new base. With this PR all leaks detected at Cobalt shutdown are plugged. See each commit for details. b/333556585

Disable currently failing wpt

8425ff2

b/332367155

Re-enable metadata validation pre-commit check (#2963)

a31a154

b/333907043

Disable currently failing wpt (#2947)

05d6cd1

b/332367155

Merge branch 'main' into feature/all-upstream-update

9a4413f

Fix compilation issues

b78e819

Filter test failure

3ea7778

Merge branch 'main' into feature/all-upstream-update (#2966)

f9e9de3

Merge branch 'main' into feature/all-upstream-update

d4c9556

Merge branch 'main' into feature/all-upstream-update (#2968)

26d746f

andrewsavage1 requested a review from a team as a code owner April 17, 2024 04:17

andrewsavage1 requested a review from johnxwork April 17, 2024 04:17

andrewsavage1 and others added 5 commits April 17, 2024 08:59

Enable all linux builds (#2928)

bf9b57f

b/334969418

Enable stub workflows without api leak detector (#2964)

23e9c15

b/334969418

Re-enable some code disabled in the first pass (#2957)

4055489

Change-Id: If07d9bc82608933369e81e62e100db63071a0958

Fix internal builds (#2962)

e889697

b/333780883

Fix lint issues in feature branch (#2970)

4708bf5

b/335357085

andrewsavage1 requested review from jellefoks, kaidokert, aee-google and sherryzy April 17, 2024 20:26

sherryzy approved these changes Apr 17, 2024

View reviewed changes

andrewsavage1 merged commit 324b566 into main Apr 17, 2024
617 of 632 checks passed

andrewsavage1 deleted the feature/all-upstream-update branch April 17, 2024 21:53

hlwarriner mentioned this pull request Jun 28, 2024

Don't optimize for size. #3711

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update base, net and dependencies #2969

Update base, net and dependencies #2969

andrewsavage1 commented Apr 17, 2024

codecov bot commented Apr 17, 2024 •

edited

Loading

datadog-cobalt-youtube bot commented Apr 17, 2024 •

edited

Loading

Update base, net and dependencies #2969

Update base, net and dependencies #2969

Conversation

andrewsavage1 commented Apr 17, 2024

codecov bot commented Apr 17, 2024 • edited Loading

Codecov Report

datadog-cobalt-youtube bot commented Apr 17, 2024 • edited Loading

Datadog Report

codecov bot commented Apr 17, 2024 •

edited

Loading

datadog-cobalt-youtube bot commented Apr 17, 2024 •

edited

Loading