Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Disable MediaPlaybackService by default" (#2211) #2528

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

zhongqiliang
Copy link
Contributor

This reverts commit 1f2d96b.

b/319146388

@zhongqiliang zhongqiliang force-pushed the revert_disable_background_playback branch from b5bee82 to 1858a51 Compare February 29, 2024 21:43
@zhongqiliang zhongqiliang force-pushed the revert_disable_background_playback branch from 1858a51 to b95702f Compare February 29, 2024 22:38
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Feb 29, 2024

Datadog Report

Branch report: revert_disable_background_playback
Commit report: de4cad2
Test service: cobalt

✅ 0 Failed, 29889 Passed, 1 Skipped, 10m 21.42s Wall Time

@zhongqiliang zhongqiliang force-pushed the revert_disable_background_playback branch from b95702f to de4cad2 Compare February 29, 2024 23:39
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.21%. Comparing base (d412241) to head (de4cad2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2528      +/-   ##
==========================================
+ Coverage   58.02%   58.21%   +0.18%     
==========================================
  Files        1781     1786       +5     
  Lines       83399    84059     +660     
==========================================
+ Hits        48392    48932     +540     
- Misses      35007    35127     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongqiliang zhongqiliang merged commit 230c7dd into main Mar 1, 2024
340 of 341 checks passed
@zhongqiliang zhongqiliang deleted the revert_disable_background_playback branch March 1, 2024 18:08
@zhongqiliang zhongqiliang added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Mar 1, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Mar 1, 2024
This reverts commit 1f2d96b.

b/319146388

---------

Co-authored-by: Colin Liang <colinliang@google.com>
(cherry picked from commit 230c7dd)
zhongqiliang added a commit that referenced this pull request Mar 18, 2024
…t" (#2211) (#2531)

Refer to the original PR: #2528

This reverts commit 1f2d96b.

b/319146388

Co-authored-by: Colin Liang <zhongqi.liang.4u@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants