Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bound set_scroll_* functions #1172

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Bound set_scroll_* functions #1172

merged 2 commits into from
Aug 7, 2023

Conversation

andrewsavage1
Copy link
Contributor

sherryzy
sherryzy approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@sherryzy sherryzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1172 (84f086b) into main (9345f29) will increase coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
+ Coverage   56.46%   56.47%   +0.01%     
==========================================
  Files        1899     1899              
  Lines       94204    94216      +12     
==========================================
+ Hits        53192    53209      +17     
+ Misses      41012    41007       -5
Files Changed Coverage Δ
cobalt/dom/html_element.cc 85.25% <100.00%> (+0.17%) ⬆️

... and 13 files with indirect coverage changes

@andrewsavage1 andrewsavage1 added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Aug 7, 2023
@andrewsavage1 andrewsavage1 merged commit 5501cf9 into youtube:main Aug 7, 2023
333 checks passed
cobalt-github-releaser-bot pushed a commit that referenced this pull request Aug 7, 2023
@andrewsavage1 @anonymous1-me
Bound set_scroll_* functions (#1172)
1dc40aa 
See https://www.w3.org/TR/cssom-view-1/#scroll-an-element

b/294602640

(cherry picked from commit 5501cf9)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Aug 7, 2023
Merged
andrewsavage1 added a commit that referenced this pull request Aug 7, 2023
@cobalt-github-releaser-bot @andrewsavage1
Cherry pick PR #1172: Bound set_scroll_* functions (#1179)
2d3fb92 
Refer to the original PR: #1172

See https://www.w3.org/TR/cssom-view-1/#scroll-an-element

b/294602640

Co-authored-by: Andrew Savage <andrewsavage@google.com>
@andrewsavage1 andrewsavage1 deleted the fix/scroll-bounds branch August 8, 2023 13:17
@andrewsavage1 andrewsavage1 mentioned this pull request Aug 8, 2023
Merged
andrewsavage1 added a commit that referenced this pull request Aug 8, 2023
@andrewsavage1
Remove cruft log (#1183)
080a25c 
Accidentally left in #1172

b/294602640
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Aug 8, 2023
Merged
cobalt-github-releaser-bot pushed a commit that referenced this pull request Aug 8, 2023
@andrewsavage1 @anonymous1-me
Remove cruft log (#1183)
a200b19 
Accidentally left in #1172

b/294602640

(cherry picked from commit 080a25c)
andrewsavage1 added a commit that referenced this pull request Aug 8, 2023
@cobalt-github-releaser-bot @andrewsavage1
Cherry pick PR #1183: Remove cruft log (#1184)
7189506 
Refer to the original PR: #1183

Accidentally left in #1172

b/294602640

Co-authored-by: Andrew Savage <andrewsavage@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherryzy sherryzy sherryzy approved these changes

@jellefoks jellefoks Awaiting requested review from jellefoks

@aee-google aee-google Awaiting requested review from aee-google

Assignees
No one assigned
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewsavage1 @sherryzy