Minor formatting cleanups (#1871)

A few include order/whitespace fixes that are preventing pre-commit --all from passing. b/199280707
youtube · Oct 30, 2023 · ee90c34 · ee90c34
1 parent 25e3f63
commit ee90c34
Show file tree

Hide file tree

Showing 13 changed files with 23 additions and 22 deletions.
diff --git a/cobalt/samples/simple_example/testdata/test_cases/case1.txt b/cobalt/samples/simple_example/testdata/test_cases/case1.txt
@@ -1 +1 @@
-1 2 4
+1 2 4
diff --git a/cobalt/samples/simple_example/testdata/test_cases/case1.txt.expected b/cobalt/samples/simple_example/testdata/test_cases/case1.txt.expected
@@ -1 +1 @@
-6
+6
diff --git a/cobalt/samples/simple_example/testdata/test_cases/case2.txt b/cobalt/samples/simple_example/testdata/test_cases/case2.txt
@@ -1 +1 @@
--3 10 15
+-3 10 15
diff --git a/cobalt/samples/simple_example/testdata/test_cases/case2.txt.expected b/cobalt/samples/simple_example/testdata/test_cases/case2.txt.expected
@@ -1 +1 @@
--15
+-15
diff --git a/cobalt/samples/simple_example/testdata/test_cases/case3.txt b/cobalt/samples/simple_example/testdata/test_cases/case3.txt
@@ -1 +1 @@
-10 -5 -4
+10 -5 -4
diff --git a/cobalt/samples/simple_example/testdata/test_cases/case3.txt.expected b/cobalt/samples/simple_example/testdata/test_cases/case3.txt.expected
@@ -1 +1 @@
--54
+-54
diff --git a/...ient/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json b/...ient/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json
@@ -1 +1 @@
-[{"output": "a_changing_text_file", "patch": "f0", "sha256": "aa607adc0b3cd83e7e9f3ebd4ae84671e2b0b288c9b7fed1e0c710025719caf5", "op": "create"}, {"output": "a_changing_binary_file", "input": "a_changing_binary_file", "patch": "f1", "sha256": "dbd6da0fd6f748b7ec95f0eed6c1f6a046d161bebb04994fe1ce730e237a733d", "op": "bsdiff"}, {"output": "manifest.json", "patch": "f2", "sha256": "1cf8d0b433c09c465994e952a79ff6980c68cc7493609f0233a4634de6276e9c", "op": "create"}, {"output": "a_static_text_file", "input": "a_static_text_file", "sha256": "806bfdfbf05afab546b3741e84fb1ccffdf75eef8629c24c5f84add2785b7bcc", "op": "copy"}]
+[{"output": "a_changing_text_file", "patch": "f0", "sha256": "aa607adc0b3cd83e7e9f3ebd4ae84671e2b0b288c9b7fed1e0c710025719caf5", "op": "create"}, {"output": "a_changing_binary_file", "input": "a_changing_binary_file", "patch": "f1", "sha256": "dbd6da0fd6f748b7ec95f0eed6c1f6a046d161bebb04994fe1ce730e237a733d", "op": "bsdiff"}, {"output": "manifest.json", "patch": "f2", "sha256": "1cf8d0b433c09c465994e952a79ff6980c68cc7493609f0233a4634de6276e9c", "op": "create"}, {"output": "a_static_text_file", "input": "a_static_text_file", "sha256": "806bfdfbf05afab546b3741e84fb1ccffdf75eef8629c24c5f84add2785b7bcc", "op": "copy"}]
diff --git a/.../ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/commands.json b/.../ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/commands.json
@@ -1 +1 @@
-[{"sha256": "806bfdfbf05afab546b3741e84fb1ccffdf75eef8629c24c5f84add2785b7bcc", "output": "a_static_text_file", "op": "copy", "input": "a_static_text_file"}, {"sha256": "1cf8d0b433c09c465994e952a79ff6980c68cc7493609f0233a4634de6276e9c", "output": "manifest.json", "op": "create", "patch": "f1"}, {"sha256": "aa607adc0b3cd83e7e9f3ebd4ae84671e2b0b288c9b7fed1e0c710025719caf5", "output": "a_changing_text_file", "op": "create", "patch": "f2"}, {"patch": "f3", "sha256": "dbd6da0fd6f748b7ec95f0eed6c1f6a046d161bebb04994fe1ce730e237a733d", "output": "a_changing_binary_file", "op": "courgette", "input": "a_changing_binary_file"}]
+[{"sha256": "806bfdfbf05afab546b3741e84fb1ccffdf75eef8629c24c5f84add2785b7bcc", "output": "a_static_text_file", "op": "copy", "input": "a_static_text_file"}, {"sha256": "1cf8d0b433c09c465994e952a79ff6980c68cc7493609f0233a4634de6276e9c", "output": "manifest.json", "op": "create", "patch": "f1"}, {"sha256": "aa607adc0b3cd83e7e9f3ebd4ae84671e2b0b288c9b7fed1e0c710025719caf5", "output": "a_changing_text_file", "op": "create", "patch": "f2"}, {"patch": "f3", "sha256": "dbd6da0fd6f748b7ec95f0eed6c1f6a046d161bebb04994fe1ce730e237a733d", "output": "a_changing_binary_file", "op": "courgette", "input": "a_changing_binary_file"}]
diff --git a/starboard/common/common.cc b/starboard/common/common.cc
@@ -17,8 +17,8 @@
 // These audits are here so they are only displayed once every build.
 
 #if SB_API_VERSION == SB_MAXIMUM_API_VERSION
-#pragma message(                                                            \
-        "Your platform's SB_API_VERSION == SB_MAXIMUM_API_VERSION. "        \
-        "You are implementing the Unreleased version of Starboard at your " \
-        "own risk!  We don't recommend this for third parties.")
+#pragma message(                                                        \
+    "Your platform's SB_API_VERSION == SB_MAXIMUM_API_VERSION. "        \
+    "You are implementing the Unreleased version of Starboard at your " \
+    "own risk!  We don't recommend this for third parties.")
 #endif
diff --git a/starboard/common/flat_map.h b/starboard/common/flat_map.h
@@ -15,14 +15,14 @@
 #ifndef STARBOARD_COMMON_FLAT_MAP_H_
 #define STARBOARD_COMMON_FLAT_MAP_H_
 
-#include "starboard/common/log.h"
-#include "starboard/types.h"
-
 #include <algorithm>
 #include <functional>
 #include <utility>
 #include <vector>
 
+#include "starboard/common/log.h"
+#include "starboard/types.h"
+
 namespace starboard {
 namespace flat_map_detail {
 // IsPod<> is a white list of common types that are "plain-old-data'.

diff --git a/starboard/elf_loader/elf.h b/starboard/elf_loader/elf.h
@@ -440,11 +440,11 @@ typedef Elf64_Sword Sword;
 #endif
 
 #define ELF32_R_SYM(val) ((val) >> 8)
-#define ELF32_R_TYPE(val) ((val)&0xff)
-#define ELF32_R_INFO(sym, type) (((sym) << 8) + ((type)&0xff))
+#define ELF32_R_TYPE(val) ((val) & 0xff)
+#define ELF32_R_INFO(sym, type) (((sym) << 8) + ((type) & 0xff))
 
 #define ELF64_R_SYM(i) ((i) >> 32)
-#define ELF64_R_TYPE(i) ((i)&0xffffffff)
+#define ELF64_R_TYPE(i) ((i) & 0xffffffff)
 #define ELF64_R_INFO(sym, type) ((((Elf64_Xword)(sym)) << 32) + (type))
 
 #define ELFMAG "\177ELF"
@@ -680,7 +680,7 @@ typedef enum RelocationTypes {
 #define PAGE_MASK (~(PAGE_SIZE - 1))
 #endif
 
-#define PAGE_START(x) ((x)&PAGE_MASK)
+#define PAGE_START(x) ((x) & PAGE_MASK)
 #define PAGE_OFFSET(x) ((x) & ~PAGE_MASK)
 #define PAGE_END(x) PAGE_START((x) + (PAGE_SIZE - 1))
 

diff --git a/starboard/shared/win32/memory_flush.cc b/starboard/shared/win32/memory_flush.cc
@@ -15,7 +15,7 @@
 #include "starboard/common/log.h"
 #include "starboard/memory.h"
 
-#include <windows.h>
+#include <windows.h>  // NOLINT(build/include_order)
 
 #if !SB_CAN(MAP_EXECUTABLE_MEMORY)
 #error \

diff --git a/starboard/shared/win32/system_symbolize.cc b/starboard/shared/win32/system_symbolize.cc
@@ -19,8 +19,9 @@
 #include <functional>
 #include <string>
 
-#include <Windows.h>  // Must go before dbghelp.h
-#include <dbghelp.h>
+// Must go before dbghelp.h
+#include <Windows.h>  // NOLINT(build/include_order)
+#include <dbghelp.h>  // NOLINT(build/include_order)
 
 #include "starboard/common/log.h"
 #include "starboard/common/mutex.h"