Re-enable test 'CallThisPointerIsNullRainyDay' (#805)

The test case 'CallThisPointerIsNullRainyDay' failed after NDK 25 upgrade because of the lack of a compilation flag. b/288107039
youtube · Aug 1, 2023 · d060bcf · d060bcf
1 parent 5da4937
commit d060bcf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/starboard/android/shared/platform_configuration/BUILD.gn b/starboard/android/shared/platform_configuration/BUILD.gn
@@ -86,6 +86,7 @@ config("platform_configuration") {
     "-fno-limit-debug-info",
     "-fcolor-diagnostics",
     "-fno-strict-aliasing",  # See http://crbug.com/32204
+    "-fno-delete-null-pointer-checks",  # see b/288107039
 
     # Default visibility is hidden to enable dead stripping.
     "-fvisibility=hidden",

diff --git a/starboard/android/shared/test_filters.py b/starboard/android/shared/test_filters.py
@@ -77,9 +77,6 @@
         # SbDrmGenerateSessionUpdateRequest().
         'SbDrmSessionTest.InvalidSessionUpdateRequestParams',
 
-        # TODO: b/288107039 This test crashed after NDK 25 upgrade, re-enable it.
-        'SbUndefinedBehaviorTest.CallThisPointerIsNullRainyDay',
-
         # TODO: b/288107692 This test crashed on arm64 after NDK 25 upgrade, re-enable it.
         'PixelTest.TooManyGlyphs',