Skip to content

Commit

Permalink
Filter test on windows instead of marking flaky (#3770)
Browse files Browse the repository at this point in the history
PosixDirectoryGetNextTest.SunnyDayStaticContent

b/302730696
  • Loading branch information
oxve authored Jul 9, 2024
1 parent c9b5dc3 commit b403700
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ TEST(PosixDirectoryGetNextTest, SunnyDay) {
EXPECT_TRUE(closedir(directory) == 0);
}

TEST(PosixDirectoryGetNextTest, FLAKY_SunnyDayStaticContent) {
TEST(PosixDirectoryGetNextTest, SunnyDayStaticContent) {
std::string testdata_dir = GetFileTestsDataDir();
EXPECT_FALSE(testdata_dir.empty());
EXPECT_TRUE(FileExists(testdata_dir.c_str()))
Expand Down
3 changes: 3 additions & 0 deletions starboard/win/win32/test_filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@

# TODO: b/349109647 Disable flaky test.
'SbPlayerGetMediaTimeTests/*',

# Known flaky on windows.
'PosixDirectoryGetNextTest.SunnyDayStaticContent',
],
'player_filter_tests': [
# These tests fail on our VMs for win-win32 builds due to missing
Expand Down

0 comments on commit b403700

Please sign in to comment.