Support flat config #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Haines <andrew@haines.org.nz>
haines
commented
Apr 9, 2024
| "files": [ | ||
| "./dist/**" | ||
| ], | ||
| "scripts": { | ||
| "build": "tsup src/index.ts --no-splitting --minify", | ||
| "build": "tsup src/index.ts --cjsInterop --dts --splitting --minify", |
There was a problem hiding this comment.
I needed to enable --cjsInterop and change the export from module.exports = to export default to get the dts file not to be empty. Unfortunately there is a bug which means that this also requires --splitting.
|
Thank you so much for your contribution! As I understand this would require a major version bump for the plugin, correct? (Since there's no backwards compatibility for export default in eslint <9 it seems like) |
|
Oh well actually thanks to the cjsInterop there's no need for a major version bump. Older versions of ESLint are compatible with this change. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
This PR adds a
metafield to the plugin, and provides type definitions, to make the plugin easy to consume in ESLint's new flat configuration format.