Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

SHOP-1372: [Aura] Add the option to display the states as a drop-down list on the new themes #436

Merged
merged 16 commits into from
Jun 10, 2024

Conversation

eihabkhan1
Copy link
Collaborator

@eihabkhan1 eihabkhan1 commented May 31, 2024

JIRA Ticket

SHOP-1372

QA Steps

  • Go to /admin/settings/payment
  • Define a custom field of type "select", make sure it's enabled
  • Make sure you use the "Aura" theme
  • In your storefront, go to a product page
  • Open the express checkout form
  • You should see the custom select field you defined rendered as a instead of
  • Try to submit the form empty, if you have the field as required you should see an error (Note: The error might display a cryptic field name, that is a bug to be fixed in a separate PR)
  • Fill out the form, and click submit.
  • The form should submit and you should be directed to the thank you page
  • Check your orders in /admin/orders, an order should be created

Note

Leave empty when you have nothing to say

@eihabkhan1 eihabkhan1 added the ⏳ in progress Still in development phase. label May 31, 2024
@eihabkhan1 eihabkhan1 self-assigned this May 31, 2024
@eihabkhan1 eihabkhan1 changed the title SHOP-1372: Add the option to display the states as a drop-down list on the new themes SHOP-1372: Aura > Add the option to display the states as a drop-down list on the new themes May 31, 2024
@eihabkhan1 eihabkhan1 changed the title SHOP-1372: Aura > Add the option to display the states as a drop-down list on the new themes SHOP-1372: [Aura] Add the option to display the states as a drop-down list on the new themes May 31, 2024
assets/express-checkout.js Outdated Show resolved Hide resolved
@AliHMIMS AliHMIMS added 🛠 Requested changes Reviewer asked for some changes to be made. and removed ⏳ in progress Still in development phase. labels Jun 5, 2024
@eihabkhan1 eihabkhan1 added 💻 Ready for review Requires a review from another developer. and removed 🛠 Requested changes Reviewer asked for some changes to be made. labels Jun 5, 2024
@AliHMIMS AliHMIMS added ✅ Reviewed PR has been reviewed and approved. and removed 💻 Ready for review Requires a review from another developer. labels Jun 6, 2024
@eihabkhan1 eihabkhan1 merged commit d7bc053 into main Jun 10, 2024
@eihabkhan1 eihabkhan1 deleted the SHOP-1372 branch June 10, 2024 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✅ Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants