Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

DARK: theme 1 > fix empty page height #408

Merged
merged 2 commits into from
Oct 19, 2023
Merged

DARK: theme 1 > fix empty page height #408

merged 2 commits into from
Oct 19, 2023

Conversation

bj-anas
Copy link
Collaborator

@bj-anas bj-anas commented Oct 19, 2023

Issue

This fix is already made in theme 3, we need to fix the height of the page if there is no content

QA Steps

  • pnpm i
  • pnpm dev
  • Check the search page height or cart page height if empty
  • Check also the collection page if you have in your store a category without items

Note

I also add empty result if their is no items in collection page

@bj-anas bj-anas added the 💻 Ready for review Requires a review from another developer. label Oct 19, 2023
@bj-anas bj-anas self-assigned this Oct 19, 2023
eihabkhan1
eihabkhan1 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@eihabkhan1 eihabkhan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bj-anas bj-anas merged commit df6dba2 into main Oct 19, 2023
@bj-anas bj-anas deleted the DARK-fix-empty-page branch October 19, 2023 10:46
@eihabkhan1 eihabkhan1 added ✅ Reviewed PR has been reviewed and approved. and removed 💻 Ready for review Requires a review from another developer. labels Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eihabkhan1 eihabkhan1 eihabkhan1 approved these changes

Assignees

@bj-anas bj-anas

Labels
✅ Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bj-anas @eihabkhan1