This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
DARK : fix product page nullable errors in console log #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bj-anas
added
💻 Ready for review
adildev101
approved these changes
Mar 16, 2023
void2023
added a commit
to youcan-shop/cod-theme-2
that referenced
this pull request
Mar 17, 2023
…from the same category (#10) * YSHOP2-141 : COD theme > Product page > Integrate the missing variants (youcan-shop#230) ## JIRA Ticket [YSHOP2-141](https://youcanshop.atlassian.net/browse/YSHOP2-141) ## QA Steps - [ ] `pnpm i` - [ ] `pnpm dev` ## Note for the custom upload image variant I will handle it in another PR [YSHOP2-141]: https://youcanshop.atlassian.net/browse/YSHOP2-141?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ * YSHOP2-191 : COD theme > Product page > Integrate the new design of uploading image variant (youcan-shop#243) ## JIRA Ticket [YSHOP2-191](https://youcanshop.atlassian.net/browse/YSHOP2-191) ## QA Steps - [ ] `pnpm i` - [ ] `pnpm dev` ## Note Leave empty when you have nothing to say [YSHOP2-191]: https://youcanshop.atlassian.net/browse/YSHOP2-191?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ * DARK : fix product page nullable errors in console log (youcan-shop#250) ## QA Steps - [ ] `pnpm i` - [ ] `pnpm dev` ## Note Leave empty when you have nothing to say * fix: remove unessecary settings * Revert "Merge remote-tracking branch 'upstream/main' into YSHOP2-151" This reverts commit 4690227, reversing changes made to f05322e. * style: add tertiary button * fix: update index template * fix: update index template --------- Co-authored-by: Anas <93322743+bj-anas@users.noreply.github.com> Co-authored-by: ybenadda <117163420+ybenadda@users.noreply.github.com>
void2023
added a commit
to youcan-shop/cod-theme-2
that referenced
this pull request
Mar 30, 2023
…n-shop#250)" This reverts commit df2d81f.
void2023
added a commit
to youcan-shop/cod-theme-2
that referenced
this pull request
Mar 30, 2023
…earchable products in one page (#27) * YSHOP2-141 : COD theme > Product page > Integrate the missing variants (youcan-shop#230) ## JIRA Ticket [YSHOP2-141](https://youcanshop.atlassian.net/browse/YSHOP2-141) ## QA Steps - [ ] `pnpm i` - [ ] `pnpm dev` ## Note for the custom upload image variant I will handle it in another PR [YSHOP2-141]: https://youcanshop.atlassian.net/browse/YSHOP2-141?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ * YSHOP2-191 : COD theme > Product page > Integrate the new design of uploading image variant (youcan-shop#243) ## JIRA Ticket [YSHOP2-191](https://youcanshop.atlassian.net/browse/YSHOP2-191) ## QA Steps - [ ] `pnpm i` - [ ] `pnpm dev` ## Note Leave empty when you have nothing to say [YSHOP2-191]: https://youcanshop.atlassian.net/browse/YSHOP2-191?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ * DARK : fix product page nullable errors in console log (youcan-shop#250) ## QA Steps - [ ] `pnpm i` - [ ] `pnpm dev` ## Note Leave empty when you have nothing to say * Dark : COD theme v1 > small minor updates in theme settings (youcan-shop#254) ## Note In this PR I have made some small changes related to fixing some sizes and ordering settings * YSHOP2-186: COD theme > Custom field issue (youcan-shop#259) * push * Revert "YSHOP2-186: COD theme > Custom field issue (youcan-shop#259)" This reverts commit 7f0814d. * Revert "Dark : COD theme v1 > small minor updates in theme settings (youcan-shop#254)" This reverts commit 5909df0. * Revert "DARK : fix product page nullable errors in console log (youcan-shop#250)" This reverts commit df2d81f. * Revert "YSHOP2-191 : COD theme > Product page > Integrate the new design of uploading image variant (youcan-shop#243)" This reverts commit ca83e2c. * ss ggg * fixes --------- Co-authored-by: Anas <93322743+bj-anas@users.noreply.github.com> Co-authored-by: Ali HMIMS <85164582+AliHMIMS@users.noreply.github.com> Co-authored-by: ybenadda <117163420+ybenadda@users.noreply.github.com>
void2023
added a commit
to youcan-shop/cod-theme-2
that referenced
this pull request
Mar 30, 2023
* YSHOP2-141 : COD theme > Product page > Integrate the missing variants (youcan-shop#230) ## JIRA Ticket [YSHOP2-141](https://youcanshop.atlassian.net/browse/YSHOP2-141) ## QA Steps - [ ] `pnpm i` - [ ] `pnpm dev` ## Note for the custom upload image variant I will handle it in another PR [YSHOP2-141]: https://youcanshop.atlassian.net/browse/YSHOP2-141?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ * YSHOP2-191 : COD theme > Product page > Integrate the new design of uploading image variant (youcan-shop#243) ## JIRA Ticket [YSHOP2-191](https://youcanshop.atlassian.net/browse/YSHOP2-191) ## QA Steps - [ ] `pnpm i` - [ ] `pnpm dev` ## Note Leave empty when you have nothing to say [YSHOP2-191]: https://youcanshop.atlassian.net/browse/YSHOP2-191?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ * DARK : fix product page nullable errors in console log (youcan-shop#250) ## QA Steps - [ ] `pnpm i` - [ ] `pnpm dev` ## Note Leave empty when you have nothing to say * Dark : COD theme v1 > small minor updates in theme settings (youcan-shop#254) ## Note In this PR I have made some small changes related to fixing some sizes and ordering settings * YSHOP2-186: COD theme > Custom field issue (youcan-shop#259) * fix: featured products by category * add display grid mixin * fix: remove comments * fix: collection page * fix: featured collections * fix: categories * fix: categories * fix: product-listing * fix: featured products by category button * fix: eof * fix --------- Co-authored-by: Anas <93322743+bj-anas@users.noreply.github.com> Co-authored-by: Ali HMIMS <85164582+AliHMIMS@users.noreply.github.com> Co-authored-by: ybenadda <117163420+ybenadda@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA Steps
pnpm ipnpm devNote
Leave empty when you have nothing to say