feat: support for recording internal audio in rooted devices (#284)

* feat: support for recording internal audio in rooted devices * fixup! feat: support for recording internal audio in rooted devices
you-apps · Apr 11, 2024 · 6663a6e · 6663a6e
1 parent 3850194
commit 6663a6e
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 4 deletions.
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -12,6 +12,10 @@
     <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
 
     <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" />
+    <uses-permission
+        android:name="android.permission.CAPTURE_AUDIO_OUTPUT"
+        tools:ignore="ProtectedPermissions" />
+
 
     <!-- Opt out for network permissions that are optional for the ExoPlayer -->
     <uses-permission

diff --git a/app/src/main/java/com/bnyro/recorder/enums/AudioDeviceSource.kt b/app/src/main/java/com/bnyro/recorder/enums/AudioDeviceSource.kt
@@ -6,7 +6,8 @@ enum class AudioDeviceSource(val value: Int) {
     DEFAULT(MediaRecorder.AudioSource.DEFAULT),
     MIC(MediaRecorder.AudioSource.MIC),
     CAMCORDER(MediaRecorder.AudioSource.CAMCORDER),
-    UNPROCESSED(MediaRecorder.AudioSource.UNPROCESSED);
+    UNPROCESSED(MediaRecorder.AudioSource.UNPROCESSED),
+    REMOTE_SUBMIX(MediaRecorder.AudioSource.REMOTE_SUBMIX);
 
     companion object {
         fun fromInt(value: Int) = AudioDeviceSource.values().first { it.value == value }

diff --git a/app/src/main/java/com/bnyro/recorder/ui/models/RecorderModel.kt b/app/src/main/java/com/bnyro/recorder/ui/models/RecorderModel.kt
@@ -10,6 +10,7 @@ import android.os.Build
 import android.os.Handler
 import android.os.IBinder
 import android.os.Looper
+import android.widget.Toast
 import androidx.activity.result.ActivityResult
 import androidx.annotation.RequiresApi
 import androidx.compose.runtime.getValue
@@ -18,7 +19,9 @@ import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.setValue
 import androidx.core.content.ContextCompat
 import androidx.lifecycle.ViewModel
+import com.bnyro.recorder.R
 import com.bnyro.recorder.canvas_overlay.CanvasOverlay
+import com.bnyro.recorder.enums.AudioDeviceSource
 import com.bnyro.recorder.enums.AudioSource
 import com.bnyro.recorder.enums.RecorderState
 import com.bnyro.recorder.services.AudioRecorderService
@@ -75,8 +78,22 @@ class RecorderModel : ViewModel() {
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
             audioPermission.add(Manifest.permission.POST_NOTIFICATIONS)
         }
+        val internalAudio = Preferences.prefs.getInt(
+            Preferences.audioDeviceSourceKey,
+            0
+        ) == AudioDeviceSource.REMOTE_SUBMIX.value
+        if (internalAudio) {
+            audioPermission.add(Manifest.permission.CAPTURE_AUDIO_OUTPUT)
+        }
 
-        if (!PermissionHelper.checkPermissions(context, audioPermission.toTypedArray())) return
+        if (!PermissionHelper.checkPermissions(context, audioPermission.toTypedArray())) {
+            Toast.makeText(
+                context,
+                context.getString(R.string.no_sufficient_permissions), Toast.LENGTH_SHORT
+            )
+                .show()
+            return
+        }
 
         val serviceIntent =
             if (Preferences.prefs.getBoolean(Preferences.losslessRecorderKey, false)) {
@@ -161,12 +178,27 @@ class RecorderModel : ViewModel() {
             Preferences.prefs.getInt(Preferences.audioSourceKey, 0) == AudioSource.MICROPHONE.value
 
         if (recordAudio) requiredPermissions.add(Manifest.permission.RECORD_AUDIO)
+
+        val internalAudio = Preferences.prefs.getInt(
+            Preferences.audioDeviceSourceKey,
+            0
+        ) == AudioDeviceSource.REMOTE_SUBMIX.value
+        if (internalAudio) requiredPermissions.add(Manifest.permission.CAPTURE_AUDIO_OUTPUT)
+
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
             requiredPermissions.add(Manifest.permission.POST_NOTIFICATIONS)
         }
 
         if (requiredPermissions.isEmpty()) return true
 
-        return PermissionHelper.checkPermissions(context, requiredPermissions.toTypedArray())
+        val granted = PermissionHelper.checkPermissions(context, requiredPermissions.toTypedArray())
+        if (!granted) {
+            Toast.makeText(
+                context,
+                context.getString(R.string.no_sufficient_permissions), Toast.LENGTH_SHORT
+            )
+                .show()
+        }
+        return granted
     }
 }
diff --git a/app/src/main/java/com/bnyro/recorder/ui/screens/SettingsScreen.kt b/app/src/main/java/com/bnyro/recorder/ui/screens/SettingsScreen.kt
@@ -173,7 +173,8 @@ fun SettingsScreen() {
                     R.string.default_audio,
                     R.string.microphone,
                     R.string.camcorder,
-                    R.string.unprocessed
+                    R.string.unprocessed,
+                    R.string.internal_audio
                 ).map {
                     stringResource(it)
                 },

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -85,4 +85,6 @@
     <string name="cant_access_selected_folder">Can\'t access selected folder!</string>
     <string name="draw_mode">Draw Mode</string>
     <string name="erase_mode">Erase Mode</string>
+    <string name="internal_audio">Internal Audio (Root)</string>
+    <string name="no_sufficient_permissions">No sufficient permissions to start recording</string>
 </resources>