Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

163 support responsive design #171

Merged
merged 3 commits into from
Sep 10, 2023
Merged

163 support responsive design #171

merged 3 commits into from
Sep 10, 2023

Conversation

hotman78
Copy link
Contributor

@hotman78 hotman78 commented Sep 1, 2023

close #163

概要

library checker のレスポンシブ対応を行った

変更前

Screenshot_2023-09-01-15-47-47-90_40deb401b9ffe8e1df2f1cc5ba480b12 Screenshot_2023-09-01-15-48-12-78_40deb401b9ffe8e1df2f1cc5ba480b12 Screenshot_2023-09-01-15-48-25-98_40deb401b9ffe8e1df2f1cc5ba480b12

変更後

Screenshot_2023-09-01-15-46-40-95_40deb401b9ffe8e1df2f1cc5ba480b12 Screenshot_2023-09-01-15-46-56-76_40deb401b9ffe8e1df2f1cc5ba480b12 Screenshot_2023-09-01-15-47-08-79_40deb401b9ffe8e1df2f1cc5ba480b12

変更点

以下の変更を加えた

  • 横幅が 600px 未満の時ヘッダーをハンバーガーメニューに切り替える
  • 数式のみの横スクロールを許可する

影響範囲

UI に大幅に変更を与えます

@hotman78 hotman78 marked this pull request as draft September 1, 2023 07:19
@hotman78
Copy link
Contributor Author

hotman78 commented Sep 1, 2023 •
edited
Loading

CIは通っている様ですが最新に追従したところ自分の環境で以下のerrorを吐いているので一旦 draft にしています

Failed to resolve import "../api/google/protobuf/timestamp" from "src/components/SubmissionTable.tsx". Does the file exist?

@hotman78
Copy link
Contributor Author

hotman78 commented Sep 1, 2023

CIは通っている様ですが最新に追従したところ自分の環境で以下のerrorを吐いているので一旦 draft にしています

Failed to resolve import "../api/google/protobuf/timestamp" from "src/components/SubmissionTable.tsx". Does the file exist?

動作確認が出来たので draft 外しました(手元の nodejs のバージョンが古いだけでした)

@hotman78 hotman78 marked this pull request as ready for review September 1, 2023 11:06
@yosupo06 yosupo06 merged commit e434f1c into yosupo06:master Sep 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ヘッダーのレスポンシブ対応
2 participants
@hotman78 @yosupo06