Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PairwiseMetric euclidean_distance(x,nil) should forward y = nil to squared_error #44

Closed
wants to merge 0 commits into from

Conversation

gmenel
Copy link
Contributor

@gmenel gmenel commented Dec 13, 2023

Prevent double calculation and use x.transpose for performance.
squared_error needs to know if nil, in order to just transpose and not recalculate.
sum_y_vec = y.nil? ? sum_x_vec.transpose : ...

@yoshoku
Copy link
Owner

yoshoku commented Dec 16, 2023

@dysonreturns
To pass checks, please rebase your branch onto latest main branch and make the commit message less than 100 characters.

@gmenel gmenel closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants